Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID :214881] Unchecked return value in subsys/mgmt/ec_host_cmd/ec_host_cmd_handler.c #29018

Closed
zephyrbot opened this issue Oct 7, 2020 · 2 comments · Fixed by #29207
Closed

[Coverity CID :214881] Unchecked return value in subsys/mgmt/ec_host_cmd/ec_host_cmd_handler.c #29018

zephyrbot opened this issue Oct 7, 2020 · 2 comments · Fixed by #29207
Assignees
@laurenmurphyx64
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/master/subsys/mgmt/ec_host_cmd/ec_host_cmd_handler.c

Category: Error handling issues
Function: handle_host_cmds_entry
Component: Other
CID: 214881

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Oct 7, 2020
@laurenmurphyx64 laurenmurphyx64 self-assigned this Oct 7, 2020
@laurenmurphyx64 laurenmurphyx64 mentioned this issue Oct 14, 2020
Merged
@jenmwms
Copy link
Collaborator

jenmwms commented Oct 15, 2020

Hi @laurenmurphyx64 I see you submitted a fix. Thanks! I'll review soon. When do you plan to update Coverity issue? Were you wanting to wait until the fix is merged to update https://scan9.coverity.com/reports.htm#v39290/p12996/fileInstanceId=71339256&defectInstanceId=8259379&mergedDefectId=214881?

@laurenmurphyx64
Copy link
Contributor

@jenmwms Thanks for the reminder! Yes, I'll wait until it's approved and merged if that's alright

laurenmurphyx64 added a commit to laurenmurphyx64/zephyr that referenced this issue Oct 19, 2020
@laurenmurphyx64
ec_host_cmd: Fix unused return value from k_sem_take call
cdbb7ef 
Fixes Coverity issue 214881.

Fixes zephyrproject-rtos#29018

Signed-off-by: Lauren Murphy <[email protected]>
galak pushed a commit that referenced this issue Oct 21, 2020
@laurenmurphyx64 @galak
ec_host_cmd: Fix unused return value from k_sem_take call
b82efb3 
Fixes Coverity issue 214881.

Fixes #29018

Signed-off-by: Lauren Murphy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurenmurphyx64 laurenmurphyx64

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ec_host_cmd: Fix unused return value from k_sem_take call laurenmurphyx64/zephyr
3 participants
@laurenmurphyx64 @zephyrbot @jenmwms