Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the use of CONFIG_KERNEL_COHERENCE #30380

Closed
ghost opened this issue Dec 2, 2020 · 0 comments · Fixed by #30502 or #31894
Closed

Improve the use of CONFIG_KERNEL_COHERENCE #30380

ghost opened this issue Dec 2, 2020 · 0 comments · Fixed by #30502 or #31894
Assignees
@andyross
Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@ghost
Copy link

ghost commented Dec 2, 2020

Describe the bug
It seems there is a typo in the kernel where KERNEL_COHERENCE is used instead of CONFIG_KERNEL_COHERENCE.

To Reproduce
Search for " KERNEL_COHERENCE". Note the leading space character.

$ git grep " KERNEL_COHERENCE"
include/spinlock.h:# ifdef KERNEL_COHERENCE
kernel/Kconfig:config KERNEL_COHERENCE
kernel/init.c:#ifdef KERNEL_COHERENCE
kernel/sched.c:#ifdef KERNEL_COHERENCE
kernel/sched.c:#ifdef KERNEL_COHERENCE
kernel/thread.c:#ifdef KERNEL_COHERENCE
kernel/timeout.c:#ifdef KERNEL_COHERENCE

Expected behavior

$ git grep " KERNEL_COHERENCE"
kernel/Kconfig:config KERNEL_COHERENCE

Impact
The conditionally compiled code (asserts) is never activated by the Kconfig option.

Environment (please complete the following information):

  • Toolchain: zephyr-sdk-0.11.4
  • Commit SHA: Observed at e0b35dd0d594a8af8989e3713f99d52128e08815

Additional context
Introduced in f6d32ab
@ghost ghost added the bug The issue is a bug, or the PR is fixing a bug label Dec 2, 2020
@nashif nashif added the priority: medium Medium impact/importance bug label Dec 2, 2020
nashif added a commit to nashif/zephyr that referenced this issue Dec 7, 2020
@nashif
kernel: fix usage of KERNEL_COHERENCE macro
7c6359b 
Add missing CONFIG_ to KERNEL_COHERENCE usage in code.

Fixes zephyrproject-rtos#30380

Signed-off-by: Anas Nashif <[email protected]>
@nashif nashif mentioned this issue Dec 7, 2020
Merged
nashif added a commit that referenced this issue Dec 8, 2020
@nashif
kernel: fix usage of KERNEL_COHERENCE macro
67c5e6b 
Add missing CONFIG_ to KERNEL_COHERENCE usage in code.

Fixes #30380

Signed-off-by: Anas Nashif <[email protected]>
@nashif nashif reopened this Dec 8, 2020
@nashif nashif mentioned this issue Dec 8, 2020
Merged
bwasim pushed a commit to bwasim/zephyr that referenced this issue Jan 5, 2021
@nashif @bwasim
kernel: fix usage of KERNEL_COHERENCE macro
effbd10 
Add missing CONFIG_ to KERNEL_COHERENCE usage in code.

Fixes zephyrproject-rtos#30380

Signed-off-by: Anas Nashif <[email protected]>
dcpleung pushed a commit to dcpleung/zephyr that referenced this issue Feb 3, 2021
@nashif @dcpleung
kernel: fix usage of KERNEL_COHERENCE macro
e9c4138 
Add missing CONFIG_ to KERNEL_COHERENCE usage in code.

Fixes zephyrproject-rtos#30380

Signed-off-by: Anas Nashif <[email protected]>
@dcpleung dcpleung mentioned this issue Feb 3, 2021
Merged
nashif added a commit that referenced this issue Feb 3, 2021
@nashif
kernel: fix usage of KERNEL_COHERENCE macro
39f632e 
Add missing CONFIG_ to KERNEL_COHERENCE usage in code.

Fixes #30380

Signed-off-by: Anas Nashif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyross andyross

Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
2 participants
@nashif @andyross