Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: controller: swi.h should use CONFIG_SOC_NRF5340_CPUNET define #30488

Closed
koffes opened this issue Dec 7, 2020 · 0 comments · Fixed by #30516
Closed

Bluetooth: controller: swi.h should use CONFIG_SOC_NRF5340_CPUNET define #30488

koffes opened this issue Dec 7, 2020 · 0 comments · Fixed by #30516
Assignees
@cvinayak
Labels
area: Bluetooth Controller bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug

Comments

@koffes
Copy link
Collaborator

koffes commented Dec 7, 2020

Describe the bug
https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/swi.h#L21
https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/swi.h#L33

These two lines should be based on SoC and not board.
@cvinayak
@koffes koffes added the bug The issue is a bug, or the PR is fixing a bug label Dec 7, 2020
@koffes koffes changed the title #ifdef in swi.h should be SoC based bluetooth: #ifdef in swi.h should be SoC based Dec 7, 2020
cvinayak added a commit to cvinayak/zephyr that referenced this issue Dec 8, 2020
@cvinayak
Bluetooth: controller: nRF53x: SWI mapping should use SOC define
09b3209 
SWI IRQ line mapping for nRF5340 shall use
CONFIG_SOC_NRF5340_CPUNET for conditional compilation
instead of the board define, so as to allow new boards to
use the BLE controller implementation.

Fixes zephyrproject-rtos#30488.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
@cvinayak cvinayak mentioned this issue Dec 8, 2020
Merged
@cvinayak cvinayak changed the title bluetooth: #ifdef in swi.h should be SoC based Bluetooth: controller: swi.h should use CONFIG_SOC_NRF5340_CPUNET define Dec 8, 2020
@nashif nashif added the priority: medium Medium impact/importance bug label Dec 15, 2020
carlescufi pushed a commit that referenced this issue Jan 6, 2021
@cvinayak @carlescufi
Bluetooth: controller: nRF53x: SWI mapping should use SOC define
db5270b 
SWI IRQ line mapping for nRF5340 shall use
CONFIG_SOC_NRF5340_CPUNET for conditional compilation
instead of the board define, so as to allow new boards to
use the BLE controller implementation.

Fixes #30488.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvinayak cvinayak

Labels
area: Bluetooth Controller bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bluetooth: controller: nRF53x: SWI mapping should use SOC define cvinayak/zephyr
4 participants
@nashif @koffes @cvinayak @carlescufi