Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make zephyr_generated_headers" regressed again - ";" separator for Z_CFLAGS instead of spaces #30712

Closed
pfalcon opened this issue Dec 14, 2020 · 3 comments · Fixed by #30714
Closed

"make zephyr_generated_headers" regressed again - ";" separator for Z_CFLAGS instead of spaces #30712

pfalcon opened this issue Dec 14, 2020 · 3 comments · Fixed by #30714
Assignees
@tejlmand
Labels
area: Build System bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug

Comments

@pfalcon
Copy link
Contributor

pfalcon commented Dec 14, 2020

make zephyr_generated_headers, as used to integrate Zephyr's build system with 3rd-party build systems, regressed again (previous case: #28230). Now it produces following Makefile.exports.C:

CC = /home/pfalcon/opt/zephyr-sdk-0.11.4/x86_64-zephyr-elf/bin/x86_64-zephyr-elf-gcc
CXX = /home/pfalcon/opt/zephyr-sdk-0.11.4/x86_64-zephyr-elf/bin/x86_64-zephyr-elf-g++
OBJCOPY = /home/pfalcon/opt/zephyr-sdk-0.11.4/x86_64-zephyr-elf/bin/x86_64-zephyr-elf-objcopy
OBJDUMP = /home/pfalcon/opt/zephyr-sdk-0.11.4/x86_64-zephyr-elf/bin/x86_64-zephyr-elf-objdump
AS = /home/pfalcon/opt/zephyr-sdk-0.11.4/x86_64-zephyr-elf/bin/x86_64-zephyr-elf-as
AR = /home/pfalcon/opt/zephyr-sdk-0.11.4/x86_64-zephyr-elf/bin/x86_64-zephyr-elf-ar
NM = /home/pfalcon/opt/zephyr-sdk-0.11.4/x86_64-zephyr-elf/bin/x86_64-zephyr-elf-nm
GDB = /home/pfalcon/opt/zephyr-sdk-0.11.4/x86_64-zephyr-elf/bin/x86_64-zephyr-elf-gdb
Z_CFLAGS = -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/include -I/home/pfalcon/projects/pycopy/ports/zephyr/outdir/qemu_x86/zephyr/include/generated -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/soc/x86/ia32 -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/lib/libc/newlib/include -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/subsys/net/lib/sockets/. -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/subsys/net/lib/dns/. -I/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/subsys/net/l2 -isystem -DKERNEL -D__ZEPHYR__=1 -D_FORTIFY_SOURCE=2 -DBUILD_VERSION=zephyr-v2.4.0-2375-g6d8fe6eae923 -D__LINUX_ERRNO_EXTENSIONS__ -Os;-imacros;/home/pfalcon/projects/pycopy/ports/zephyr/outdir/qemu_x86/zephyr/include/generated/autoconf.h;-ffreestanding;-fno-common;-g;-m32;-Wa,--divide;-imacros;/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/include/toolchain/zephyr_stdint.h;-Wall;-Wformat;-Wformat-security;-Wno-format-zero-length;-Wno-main;-Wno-pointer-sign;-Wpointer-arith;-Wno-address-of-packed-member;-Wno-unused-but-set-variable;-Werror=implicit-int;-fno-asynchronous-unwind-tables;-fno-pie;-fno-pic;-fno-strict-overflow;-fno-reorder-functions;-fno-defer-pop;-fmacro-prefix-map=/home/pfalcon/projects/pycopy/ports/zephyr=CMAKE_SOURCE_DIR;-fmacro-prefix-map=/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr=ZEPHYR_BASE;-fmacro-prefix-map=/mnt/hdd/projects-3rdparty/Embedded/Zephyr=WEST_TOPDIR;-ffunction-sections;-fdata-sections;-mpreferred-stack-boundary=2;-mno-sse;-std=c99

The culprit is in the generated Z_CFLAGS - after some option, the separator suddenly changes from " " (space) to ";".
@pfalcon pfalcon added bug The issue is a bug, or the PR is fixing a bug area: Build System labels Dec 14, 2020
@pfalcon
Copy link
Contributor Author

pfalcon commented Dec 14, 2020

I didn't do detailed triaging/bisecting yet, pretty late for me, may fall asleep before I finish. Assigning to you, @tejlmand, just in case, hopefully you'll be able to help, just as with the previous case above. Thanks.

@pfalcon
Copy link
Contributor Author

pfalcon commented Dec 14, 2020

Ok, 8275d39 broke it, with telling title "cmake: adding $ instead of space on zephyr_get_compile_".

@nashif nashif added the priority: high High impact/importance bug label Dec 14, 2020
tejlmand added a commit to tejlmand/zephyr that referenced this issue Dec 14, 2020
@tejlmand
cmake: using zephyr_get_compile_options_for_lang_as_string for export
025e47a 
Fixes: zephyrproject-rtos#30712

Now using zephyr_get_compile_options_for_lang_as_string for makefile
export of Zephyr build flags.

Signed-off-by: Torsten Rasmussen <[email protected]>
@tejlmand tejlmand mentioned this issue Dec 14, 2020
Merged
@tejlmand
Copy link
Collaborator

Fived here: #30714

nashif pushed a commit that referenced this issue Dec 15, 2020
@tejlmand @nashif
cmake: using zephyr_get_compile_options_for_lang_as_string for export
a019b6f 
Fixes: #30712

Now using zephyr_get_compile_options_for_lang_as_string for makefile
export of Zephyr build flags.

Signed-off-by: Torsten Rasmussen <[email protected]>
bwasim pushed a commit to bwasim/zephyr that referenced this issue Jan 5, 2021
@tejlmand @bwasim
cmake: using zephyr_get_compile_options_for_lang_as_string for export
a203806 
Fixes: zephyrproject-rtos#30712

Now using zephyr_get_compile_options_for_lang_as_string for makefile
export of Zephyr build flags.

Signed-off-by: Torsten Rasmussen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tejlmand tejlmand

Labels
area: Build System bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: using zephyr_get_compile_options_for_lang_as_string for export tejlmand/zephyr
3 participants
@nashif @pfalcon @tejlmand