Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-existent event in asynchronous UART API #31207

Closed
Trubochkin opened this issue Jan 10, 2021 · 0 comments · Fixed by #31897
Closed

Non-existent event in asynchronous UART API #31207

Trubochkin opened this issue Jan 10, 2021 · 0 comments · Fixed by #31897
Assignees
@jenmwms
Labels
area: Drivers bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@Trubochkin
Copy link

There is an incorrect event name UART_RX_DONE :

zephyr/include/drivers/uart.h

Line 51 in c22f7e5

* - Ignore the event, this way when current buffer is filled UART_RX_DONE

Apparently the author made a mistake in the event name. There shuld be UART_RX_RDY
@nashif nashif added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels Feb 2, 2021
@jenmwms jenmwms self-assigned this Feb 3, 2021
jenmwms added a commit that referenced this issue Feb 3, 2021
@jenmwms
include: drivers: uart: fix incorrect event name in brief
04d3d4e 
The use of UART_RX_DONE was incorrect/invalid (the event does not exist).
This corrects the reference to UART_RX_RDY.

Fixes #31207

Signed-off-by: Jennifer Williams <[email protected]>
@jenmwms jenmwms mentioned this issue Feb 3, 2021
Closed
@jenmwms jenmwms added the has-pr label Feb 3, 2021
jenmwms added a commit to jenmwms/zephyr that referenced this issue Feb 3, 2021
@jenmwms
include: drivers: uart: fix incorrect event name in brief
7e1cc4f 
The use of UART_RX_DONE was incorrect/invalid (the event
does not exist). This corrects the reference to UART_RX_RDY.

Fixes zephyrproject-rtos#31207

Signed-off-by: Jennifer Williams <[email protected]>
@jenmwms jenmwms mentioned this issue Feb 3, 2021
Merged
nashif pushed a commit that referenced this issue Feb 3, 2021
@jenmwms @nashif
include: drivers: uart: fix incorrect event name in brief
783f815 
The use of UART_RX_DONE was incorrect/invalid (the event
does not exist). This corrects the reference to UART_RX_RDY.

Fixes #31207

Signed-off-by: Jennifer Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenmwms jenmwms

Labels
area: Drivers bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
3 participants
@nashif @Trubochkin @jenmwms