Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: controller: Compilation error when Encryption support is disabled #31693

Closed
cvinayak opened this issue Jan 27, 2021 · 0 comments · Fixed by #31694
Closed

Bluetooth: controller: Compilation error when Encryption support is disabled #31693

cvinayak opened this issue Jan 27, 2021 · 0 comments · Fixed by #31694
Assignees
Labels
area: Bluetooth Controller area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Milestone

Comments

@cvinayak
Copy link
Contributor

Describe the bug
tests/bluetooth/mesh_shell for pca10056 it fails to compile with error

/home/user/work/zephyr/subsys/bluetooth/controller/ll_sw/ull_conn.c: In function 'event_conn_upd_prep':
/home/user/work/zephyr/subsys/bluetooth/controller/ll_sw/ull_conn.c:2350:37: error: 'struct <anonymous>' has no member named 'llcp_type'
 2350 |   if (conn->lll.role && (conn->slave.llcp_type != LLCP_NONE)) {
      |                                     ^
/home/user/work/zephyr/subsys/bluetooth/controller/ll_sw/ull_conn.c:2354:15: error: 'struct <anonymous>' has no member named 'llcp_type'
 2354 |    conn->slave.llcp_type = LLCP_NONE;
      |               ^
/home/user/work/zephyr/subsys/bluetooth/controller/ll_sw/ull_conn.c: In function 'event_ch_map_prep':
/home/user/work/zephyr/subsys/bluetooth/controller/ll_sw/ull_conn.c:2634:37: error: 'struct <anonymous>' has no member named 'llcp_type'
 2634 |   if (conn->lll.role && (conn->slave.llcp_type != LLCP_NONE)) {
      |                                     ^
/home/user/work/zephyr/subsys/bluetooth/controller/ll_sw/ull_conn.c:2638:15: error: 'struct <anonymous>' has no member named 'llcp_type'
 2638 |    conn->slave.llcp_type = LLCP_NONE;

This project has encryption disabled and this field is not present. When I enabled enc BT_CTLR_LE_ENC it compiled.

Also, building controller only with no encryption has compile errors.

To Reproduce
Steps to reproduce the behavior:

  1. mkdir build; cd build
  2. cmake -GNinja -DBOARD=nrf52840dk_nrf52840 ../samples/bluetooth/hci_uart
  3. make
  4. See error

Expected behavior
Application should compile clean.

Impact
showstopper

Logs and console output
If applicable, add console logs or other types of debug information
e.g Wireshark capture or Logic analyzer capture (upload in zip archive).
copy-and-paste text and put a code fence (```) before and after, to help
explain the issue. (if unable to obtain text log, add a screenshot)

Environment (please complete the following information):

  • OS: Linux
  • Toolchain Zephyr SDK
  • Commit SHA or Version used: fc03bd2

Additional context
Add any other context about the problem here.

@cvinayak cvinayak added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug area: Bluetooth area: Bluetooth Controller labels Jan 27, 2021
@cvinayak cvinayak added this to the v2.5.0 milestone Jan 27, 2021
@cvinayak cvinayak self-assigned this Jan 27, 2021
cvinayak added a commit to cvinayak/zephyr that referenced this issue Jan 27, 2021
Fix compilation error with encryption support disabled in the
controller.

Fixes zephyrproject-rtos#31693.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
nashif pushed a commit that referenced this issue Jan 27, 2021
Fix compilation error with encryption support disabled in the
controller.

Fixes #31693.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Controller area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant