Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: Unhandled error in NVS backend #31907

Closed
lmaciejonczyk opened this issue Feb 3, 2021 · 0 comments · Fixed by #31870
Closed

settings: Unhandled error in NVS backend #31907

lmaciejonczyk opened this issue Feb 3, 2021 · 0 comments · Fixed by #31870
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@lmaciejonczyk
Copy link
Contributor

lmaciejonczyk commented Feb 3, 2021

Describe the bug
I we try to store data which exceeds the available size the NVS settings backend returns success but fails in real.

To Reproduce
Call: settings_save_one( path, p_data, INT_MAX )
Tested on: nrf52840dk_nrf52840 with SETTINGS_NVS enabled

Expected behavior
The function: settings_nvs_save() should return failure code but instead it returns ok.

Impact
Unit tests are not passing: nrfconnect/sdk-nrf#3806

Logs and console output

Environment (please complete the following information):

Additional context
This PR fixes the bug: #31870

@lmaciejonczyk lmaciejonczyk added the bug The issue is a bug, or the PR is fixing a bug label Feb 3, 2021
@nvlsianpu nvlsianpu added the priority: low Low impact/importance bug label Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants