Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: Handle unhandled error #31870

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

lmaciejonczyk
Copy link
Contributor

@lmaciejonczyk lmaciejonczyk commented Feb 2, 2021

There was a case when the return code was ignored. This PR fixes it.

Issue reference: #31907
fixes #31907

There was a case when the return code was ignored. This commit
fixes it.

Signed-off-by: Lukasz Maciejonczyk <[email protected]>
@github-actions github-actions bot added the area: Settings Settings subsystem label Feb 2, 2021
Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@nvlsianpu nvlsianpu added the bug The issue is a bug, or the PR is fixing a bug label Feb 3, 2021
@nvlsianpu nvlsianpu requested a review from nashif February 3, 2021 09:30
@Laczen Laczen self-requested a review February 3, 2021 09:30
Copy link
Collaborator

@Laczen Laczen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks.

@nashif nashif merged commit 563c24f into zephyrproject-rtos:master Feb 3, 2021
@lmaciejonczyk lmaciejonczyk deleted the settings_nvs_fix branch May 17, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Settings Settings subsystem bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

settings: Unhandled error in NVS backend
5 participants