Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posix: rename priority in sched_param struct #13497

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

nashif
Copy link
Member

@nashif nashif commented Feb 18, 2019

Priority member in the sched_param struct should be named
sched_priority.

Fixes #13470

Priority member in the sched_param struct should be named
sched_priority.

Fixes zephyrproject-rtos#13470

Signed-off-by: Anas Nashif <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #13497 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13497      +/-   ##
==========================================
+ Coverage    52.5%   52.53%   +0.02%     
==========================================
  Files         318      318              
  Lines       46526    46532       +6     
  Branches    10754    10759       +5     
==========================================
+ Hits        24429    24445      +16     
+ Misses      17198    17188      -10     
  Partials     4899     4899
Impacted Files Coverage Δ
include/posix/posix_sched.h 100% <ø> (ø) ⬆️
lib/posix/pthread.c 80% <100%> (ø) ⬆️
drivers/clock_control/nrf_power_clock.c 50% <0%> (-2.11%) ⬇️
lib/os/fdtable.c 42.22% <0%> (-0.48%) ⬇️
boards/posix/nrf52_bsim/time_machine.c 52.45% <0%> (+4.91%) ⬆️
boards/posix/nrf52_bsim/argparse.c 46.98% <0%> (+15.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e73c9...9860094. Read the comment docs.

Copy link

@nniranjhana nniranjhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can confirm all instances have been replaced.

Copy link
Contributor

@pfalcon pfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified by looking at http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sched.h.html . Ideally, the commit message would include link/quote from it.

@nashif nashif merged commit 04743c9 into zephyrproject-rtos:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants