[DNM] cmake toolchain cleanup system include handling

[galak]

No description provided.

[galak]

All this is a wip in progress to cleanup how we get the include path for libgcc, libc, and c++ headers. This seems to fix libc with the SDK toolchain and cross-toolchain on fedora.

@aurel32 can you try this on debian.

[zephyrbot]

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

[codecov-io]

Codecov Report

Merging #13648 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13648      +/-   ##
==========================================
- Coverage   52.51%   52.48%   -0.04%     
==========================================
  Files         329      329              
  Lines       46910    46910              
  Branches    10811    10811              
==========================================
- Hits        24637    24621      -16     
- Misses      17340    17352      +12     
- Partials     4933     4937       +4

Impacted Files	Coverage Δ
subsys/testsuite/ztest/include/ztest_assert.h	35% <0%> (-35%)	⬇️
subsys/testsuite/ztest/src/ztest.c	65.28% <0%> (-7.44%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82616a6...e8f2ffa. Read the comment docs.

[aurel32]

All this is a wip in progress to cleanup how we get the include path for libgcc, libc, and c++ headers. This seems to fix libc with the SDK toolchain and cross-toolchain on fedora.

I still do not get why we use -notstdinc if we just re-add all those path manually.

@aurel32 can you try this on debian.

It works for finding the libc, but it doesn't work for C++ headers, neither in debian nor with SDK 0.1.0. You can find a way to test that in PR #13646

[aurel32]

All this is a wip in progress to cleanup how we get the include path for libgcc, libc, and c++ headers. This seems to fix libc with the SDK toolchain and cross-toolchain on fedora.

I still do not get why we use -notstdinc if we just re-add all those path manually.

Also note that this strategy will not work for include paths added by a spec file, like it should be done in PR #12735 (but it's not done like that yet).

[marc-h38]

About the [DNM] tag: https://github.blog/2019-02-14-introducing-draft-pull-requests/