disk: fixing the sending of commands with r1 response #15790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we have a PR against master? Can you please open an issue for 1.14. |
Do I need to create another PR, this time against master, beyond this? |
|
Needs a rebase onto master |
The sdhc_cmd_r1_raw() function doesn't take into account the existence of commands with data response. Because of this, some datas were being lost. The commands that return a r1 response and a data are: SDHC_SEND_CSD, SDHC_SEND_CID, SDHC_READ_SINGLE_BLOCK, SDHC_READ_MULTIPLE_BLOCK, SDHC_WRITE_BLOCK, SDHC_WRITE_MULTIPLE_BLOCK. In order to solve this, was juts necessary skip the byte discard when the command is one of these. This problem was affecting, for example, the sdhc initialization. The token returned from SDHC_SEND_CSD was being lost and the initialization was broken. Fixes zephyrproject-rtos#15444. Signed-off-by: Lucas Peixoto <[email protected]>
pabigot
requested changes
Jul 18, 2019
I can push the rebase if necessary. |
Please, push the rebase. Thanks in advance. |
|
@lucaspeixotot Sorry, turns out I can't push to this PR. So I added a new PR to replace this, and will handle the backport as well. Thanks for providing the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sdhc_cmd_r1_raw() function doesn't take into account the existence
of commands with data response. Because of this, some datas were being
lost.
The commands that return a r1 response and a data are: SDHC_SEND_CSD,
SDHC_SEND_CID, SDHC_READ_SINGLE_BLOCK, SDHC_READ_MULTIPLE_BLOCK,
SDHC_WRITE_BLOCK, SDHC_WRITE_MULTIPLE_BLOCK.
In order to solve this, was juts necessary skip the byte discard when
the command is one of these.
This problem was affecting, for example, the sdhc initialization. The
token returned from SDHC_SEND_CSD was being lost and the initialization
was broken.
Fixes #15444.
Signed-off-by: Lucas Peixoto [email protected]