[topic-usb]usb: remove obsolete request handlers array #26854
Conversation
jfischer-no
requested review from
finikorg,
galak,
MaureenHelm and
nashif
as code owners
|
I think We should also update drivers to use new struct and delete all of this. |
yes, but I wanted to discuss it first. |
subsys/usb/usb_device.c
Outdated
| if (handler == NULL) { | ||
| LOG_DBG("No handler for reqtype %d", type); | ||
| switch (setup->RequestType.type) { | ||
| case REQTYPE_TYPE_STANDARD: |
There was a problem hiding this comment.
nit: change the double space to a single space.
There was a problem hiding this comment.
thanks, will fix (@nzmichaelh Please "request changes" for this kind of issues)
include/usb/usb_device.h
Outdated
| @@ -81,9 +81,24 @@ extern "C" { | |||
| * USB application interface | |||
| **************************************************************************/ | |||
|
|
|||
| struct usb_req_type_field { | |||
| #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ | |||
There was a problem hiding this comment.
In Bluetooth we do it the same way:
https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/bluetooth/controller/ll_sw/pdu.h#L192
There was a problem hiding this comment.
I think it is perfectly fine to use bitfields in packed structures, provided the endian macros are used like in this example.
jfischer-no
force-pushed
the
pr-usb-bmrequesttype
branch
from
3b893b0 to
839b40f
Compare
|
@emob-nordic please review |
| static int usb_handle_standard_request(struct usb_setup_packet *setup, | ||
| int32_t *len, uint8_t **data_buf); | ||
| static int class_handler(struct usb_setup_packet *pSetup, | ||
| int32_t *len, uint8_t **data); | ||
| static int vendor_handler(struct usb_setup_packet *pSetup, | ||
| int32_t *len, uint8_t **data); | ||
| static int custom_handler(struct usb_setup_packet *pSetup, | ||
| int32_t *len, uint8_t **data); | ||
|
|
There was a problem hiding this comment.
This could actually be avoided, don't You want to do that?
There was a problem hiding this comment.
I agree, it is temporary, I did not want to do it yet. There is still some stuff to clean up, then we can reorganize it more logical.
|
I will reorganize it and open an other PR to rework and cleanup public headers. |
Apart from the fixed standard request handler, custom, class, and vendor handlers are handled on the basis of class/functions. Handlers array and its initialization is no longer necessary. Signed-off-by: Johann Fischer <[email protected]>
jfischer-no
force-pushed
the
pr-usb-bmrequesttype
branch
from
839b40f to
255546d
Compare
Remove obsolete request handlers array.
Apart from the fixed standard request handler,
custom, class, and vendor handlers are handled
on the basis of class/functions.
Handlers array and its initialization is no longer necessary.
Add bit-field vor bmRequestType.