Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Enable DesignWare SPI for EOS S3 #28762

Closed

Conversation

kowalewskijan
Copy link
Contributor

@kowalewskijan kowalewskijan commented Sep 29, 2020

This PR:

  • Adds SPI driver for EOS S3 SoC along with necessary configurations
  • Enables DesignWare SPI driver for the QuickFeather board
  • Adds QuickFeather target to SPI tests
  • Enables NOR SPI Flash for the QuickFeather board
  • Enables drivers/spi_flash sample for the QuickFeather target

Remaining work:

  • EOS S3 needs custom IRQ clear (in WIC controller) for SPI which is currently not implemented, hence the SPI peripheral won't work correctly until this part is done.

@tbursztyka
Copy link
Collaborator

tbursztyka commented Nov 24, 2020

missed that PR.

Is it me or the SPI IP block is DesignWare? (registers have same names)

@kowalewskijan ?

@kowalewskijan
Copy link
Contributor Author

@tbursztyka it seems you might be right. I checked the reference manual and registers names and offsets match too. I'll try to use the spi_dw driver. Thanks for pointing it out!

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Mar 22, 2021
@kowalewskijan kowalewskijan force-pushed the add-eos-s3-spi-driver branch from 2aeeaf6 to a28e3c3 Compare March 23, 2021 14:12
@kowalewskijan kowalewskijan changed the title Add EOS S3 SPI support WIP: Add EOS S3 SPI support Mar 23, 2021
@github-actions github-actions bot added the area: Tests Issues related to a particular existing or missing test label Mar 23, 2021
@kowalewskijan
Copy link
Contributor Author

@tbursztyka could you remove the stale label from this PR? I pushed some WIP code with the DesignWare configuration for EOS-S3 but still I need to work on it.

@github-actions github-actions bot removed the Stale label Mar 24, 2021
@kowalewskijan kowalewskijan force-pushed the add-eos-s3-spi-driver branch from a28e3c3 to 2306ae4 Compare April 8, 2021 16:40
kowalewskijan and others added 3 commits April 27, 2021 10:50
WIP DesignWare SPI configuration for QuickFeather board

Signed-off-by: Jan Kowalewski <[email protected]>
Add quick_feather.conf for spi_loopback test

Signed-off-by: Jan Kowalewski <[email protected]>
Configure and enable NOR SPI Flash for EOS S3 Quick Feather board.

Signed-off-by: Jan Kowalewski <[email protected]>
@kowalewskijan kowalewskijan force-pushed the add-eos-s3-spi-driver branch from 2306ae4 to 737477e Compare April 27, 2021 08:52
@kowalewskijan kowalewskijan changed the title WIP: Add EOS S3 SPI support WIP: Enable DesignWare SPI for EOS S3 Apr 27, 2021
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jul 14, 2021
@github-actions github-actions bot closed this Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Boards area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: Samples Samples area: SPI SPI bus area: Tests Issues related to a particular existing or missing test Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants