Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements for the eth_mcux driver #28874

Merged
merged 10 commits into from
Oct 9, 2020
Merged

Various improvements for the eth_mcux driver #28874

merged 10 commits into from
Oct 9, 2020

Conversation

armandciejak
Copy link
Contributor

@armandciejak armandciejak commented Oct 2, 2020 •
edited
Loading

Here is the list of improvements:

  • Implement set_config
  • Use devicetree status okay instead of CONFIG_ETH_MCUX_*
  • Make eth_context.clock correct for both Kinetis and i.MX RT
  • Simplify MAC address assignment function: there is now a single function defined per instance
  • Other small things

NOTE: There should be absolutely no functional change.

@galak galak requested review from agansari and jukkar October 2, 2020 15:46
@armandciejak armandciejak force-pushed the eth-mcux-improvements branch 2 times, most recently from 0c0fbf9 to 01b12c1 Compare October 5, 2020 07:40
@github-actions github-actions bot added the area: Samples Samples label Oct 5, 2020
jukkar
jukkar reviewed Oct 5, 2020
View reviewed changes
drivers/ethernet/eth_mcux.c Outdated Show resolved Hide resolved
drivers/ethernet/CMakeLists.txt Outdated Show resolved Hide resolved
@AntoineZen
eth: mcux: Implement set_config
132e53b 
This allows setting the MAC address at run time.

Signed-off-by: Antoine Zen-Ruffinen <[email protected]>
Signed-off-by: Armand Ciejak <[email protected]>
@armandciejak armandciejak force-pushed the eth-mcux-improvements branch from 01b12c1 to 972a399 Compare October 5, 2020 09:37
@armandciejak armandciejak mentioned this pull request Oct 5, 2020
Closed
agansari
agansari suggested changes Oct 5, 2020
View reviewed changes
drivers/ethernet/eth_mcux.c Show resolved Hide resolved
drivers/ethernet/eth_mcux.c Show resolved Hide resolved
Armand Ciejak added 9 commits October 5, 2020 18:54
eth: mcux: Get rid of CONFIG_ETH_MCUX_*
e4bf206 
Use node's status in device tree instead.

Signed-off-by: Armand Ciejak <[email protected]>
eth: mcux: Replace hard-coded eth_context.clock
de5bea4 
This fixes wrong value for i.MX RT.
This is one less hard-coded value in eth_N_context structures.

Signed-off-by: Armand Ciejak <[email protected]>
eth: mcux: Do not compile phy_state_name() if not used
3f70619 
This is better than declaring it unused.

Signed-off-by: Armand Ciejak <[email protected]>
eth: mcux: Do not call eth_name() when dev->name can be used
f2f21f5 
Spare a function call.

Signed-off-by: Armand Ciejak <[email protected]>
eth: mcux: Rework MAC address assignment functions
ea10a52 
Do not override OUI of the local MAC address in the devicetree.
Simplify the mac address assignment conditions. Each interface has
its own function. Code duplication will be eliminated with the
use of DT_INST_FOREACH_STATUS_OKAY in a later commit to completely
remove duplicated code.
The 3 possible MAC address assignment (local, random and unique)
are covered and have been tested.

Signed-off-by: Armand Ciejak <[email protected]>
eth: mcux: Make consistent use of #if defined
a70eca3 
As well as #ifndef.
Apply it for all CONFIG_* defines.

Signed-off-by: Armand Ciejak <[email protected]>
eth: mcux: Enable PTP IRQ only if the ptp node is enabled
9a9ad01 
This covers the case of 1 controller having PTP enabled and
the other not.

Signed-off-by: Armand Ciejak <[email protected]>
eth: mcux: Rename eth_* to eth* to be have consistent naming
80c4ed1 
Both eth_* and eth* were used before.

Signed-off-by: Armand Ciejak <[email protected]>
eth: mcux: Fix typo in define name
a0db435 
VALN -> VLAN

Signed-off-by: Armand Ciejak <[email protected]>
@armandciejak armandciejak force-pushed the eth-mcux-improvements branch from 972a399 to a0db435 Compare October 5, 2020 16:54
@armandciejak armandciejak requested a review from dleach02 October 8, 2020 06:50
@carlescufi carlescufi merged commit 1faf2a9 into zephyrproject-rtos:master Oct 9, 2020
@agansari agansari mentioned this pull request Oct 9, 2020
Merged
chrta added a commit to lemonbeat/zephyr that referenced this pull request Nov 5, 2020
@chrta
drivers: ethernet: stm32: Add missing net_if_set_link_addr() call
9564eef 
When setting the MAC address, the ethernet driver has to call
net_if_set_link_addr() with the updated address. This was missing and is
added now.
See e.g.
zephyrproject-rtos#28874

Signed-off-by: Christian Taedcke <[email protected]>
@chrta chrta mentioned this pull request Nov 5, 2020
Merged
jukkar pushed a commit that referenced this pull request Nov 6, 2020
@chrta @jukkar
drivers: ethernet: stm32: Add missing net_if_set_link_addr() call
8910d1c 
When setting the MAC address, the ethernet driver has to call
net_if_set_link_addr() with the updated address. This was missing and is
added now.
See e.g.
#28874

Signed-off-by: Christian Taedcke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agansari agansari agansari approved these changes

@dleach02 dleach02 dleach02 approved these changes

@jukkar jukkar jukkar approved these changes

Assignees
No one assigned
Labels
area: Boards area: Networking area: Samples Samples platform: NXP NXP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@armandciejak @jukkar @dleach02 @agansari @carlescufi @AntoineZen