sanitycheck: Add Zephyr's version as a property to xml reports #29172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds posibility to save zephyr version in the xml reports. It adds 'properties' attribute to testsuite attribute. 'properties' can contain multiple 'property' attributes. Zephyr version is added as such 'property'. Signed-off-by: Maciej Perkowski <[email protected]>
github-actions
bot
added
the
area: Sanitycheck
PerMac
force-pushed
the
property_xml_report
branch
from
e861c0d to
b8dd30b
Compare
|
I followed a scheme for junit report shown here: https://llg.cubic.org/docs/junit/ when adding 'properties' |
abrodkin
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
Thanks! That looks pretty cool now!
Execution of ./scripts/sanitycheck --test tests/subsys/logging/log_immediate/lo gging.log_immediate.clean_output --platform nsim_hs --platform nsim_em gave me the following sanity-out/sanitycheck.xml.
<testsuites>
<testsuite errors="0" failures="0" name="nsim_hs" skipped="0" tests="1" time="3.599809">
<properties>
<property name="version" value="zephyr-v2.4.0-559-gb8dd30b2d6" />
</properties>
<testcase classname="nsim_hs:tests/subsys/logging/log_immediate/logging.log_immediate" name="tests/subsys/logging/log_immediate/logging.log_immediate.clean_output" time="3.599809" />
</testsuite>
<testsuite errors="0" failures="0" name="nsim_em" skipped="0" tests="1" time="3.685498">
<properties>
<property name="version" value="zephyr-v2.4.0-559-gb8dd30b2d6" />
</properties>
<testcase classname="nsim_em:tests/subsys/logging/log_immediate/logging.log_immediate" name="tests/subsys/logging/log_immediate/logging.log_immediate.clean_output" time="3.685498" />
</testsuite>
</testsuites>My only comment would be to maybe move a platform name from testsute's "name" to the "platfrom" property. But I guess that could be done separately.
aasthagr
reviewed
Oct 14, 2020
Adds function checking the version of zephyr, used for reporting Signed-off-by: Maciej Perkowski <[email protected]>
PerMac
force-pushed
the
property_xml_report
branch
from
b8dd30b to
7b5052b
Compare
aasthagr
approved these changes
Oct 15, 2020
nashif
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checking and reporting the version of Zephyr used by sanitycheck (via
git describe)