Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport v1.14] push ssf to thread privileged stack to complete stack frame #29536

Merged
merged 2 commits into from
Nov 16, 2020
Merged

[backport v1.14] push ssf to thread privileged stack to complete stack frame #29536

merged 2 commits into from
Nov 16, 2020

Conversation

wentongwu
Copy link
Contributor

  1. push ssf to thread privileged stack to complete stack frame
  2. add more than 6 arguments syscall test case

Fixes: #29386.

@wentongwu wentongwu changed the title Syscall push ssf to thread privileged stack to complete stack frame Oct 26, 2020
@wentongwu
arch: arm: push ssf to thread privileged stack to complete stack frame
1704078 
All system call handlers have the same prototype:
u32_t _handler_APINAME(u32_t arg1, u32_t arg2, u32_t arg3,
		       u32_t arg4, u32_t arg5, u32_t arg6, void *ssf);

This commit pushes the seventh argument named ssf to thread's privileged
stack to avoid mis-understanding the stack layout with compiler.

Fixes: zephyrproject-rtos#29386.

Signed-off-by: Wentong Wu <[email protected]>
@wentongwu
tests: kernel: syscalls: add more than 6 arguments syscall test case
cc6ac9d 
Add more than 6 arguments syscall test case.

Signed-off-by: Wentong Wu <[email protected]>
@wentongwu wentongwu requested a review from pabigot October 27, 2020 02:39
@pabigot pabigot changed the title push ssf to thread privileged stack to complete stack frame [backport v1.14] push ssf to thread privileged stack to complete stack frame Oct 27, 2020
@nashif nashif added Backport Backport PR and backport failure issues and removed backport v1.14-branch labels Oct 27, 2020
@nashif nashif added this to the v1.14.3 milestone Oct 27, 2020
@wentongwu wentongwu requested a review from jocelyn-li October 30, 2020 09:22
@wentongwu
Copy link
Contributor Author

@andrewboie @ioannisg ping...

@wentongwu
Copy link
Contributor Author

@ioannisg please also review this PR, thanks.

@nashif nashif merged commit 3de7d21 into zephyrproject-rtos:v1.14-branch Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewboie andrewboie andrewboie approved these changes

@ioannisg ioannisg Awaiting requested review from ioannisg

@andyross andyross Awaiting requested review from andyross andyross is a code owner

@galak galak Awaiting requested review from galak galak is a code owner

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm MaureenHelm is a code owner

@nashif nashif Awaiting requested review from nashif nashif is a code owner

@pabigot pabigot Awaiting requested review from pabigot

@jocelyn-li jocelyn-li Awaiting requested review from jocelyn-li

Assignees

@nashif nashif

Labels
Backport Backport PR and backport failure issues
Projects
Backports
Status: Done
Milestone
v1.14.3
Development

Successfully merging this pull request may close these issues.
3 participants
@wentongwu @andrewboie @nashif