Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitycheck: handle overflow skips #29717

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

nashif
Copy link
Member

@nashif nashif commented Nov 2, 2020

skips due to ram/rom overflow were captured as failures. Fix this and count
them correctly as skips.

Fixes #29412

Count tests that were skipped due to SRAM/RAM overdlow as skipped.

Signed-off-by: Anas Nashif <[email protected]>
@nashif nashif requested a review from PerMac November 2, 2020 13:49
@github-actions github-actions bot added the area: Sanitycheck Sanitycheck has been renamed to Twister label Nov 2, 2020
@nashif nashif requested a review from maksimmasalski November 2, 2020 13:49
skips due to ram/rom overflow were captured as failures. Fix this and
count them correctly as skips.

Fixes zephyrproject-rtos#29412

Signed-off-by: Anas Nashif <[email protected]>
@nashif nashif force-pushed the sanitycheck/overflow_skip branch from dde2610 to 905ccfc Compare November 2, 2020 13:52
Copy link
Collaborator

@maksimmasalski maksimmasalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now test counts as skipped, correct.

INFO    - 1/1 mec15xxevb_assy6853       tests/portability/cmsis_rtos_v2/portability.cmsis_rtos_v2 SKIPPED (SRAM overflow)

@nashif nashif merged commit be1025a into zephyrproject-rtos:master Nov 2, 2020
@nashif nashif deleted the sanitycheck/overflow_skip branch November 2, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sanitycheck Sanitycheck has been renamed to Twister
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sanitycheck: skipped tests marked as failed due to the reason SKIPPED (SRAM overflow)
3 participants