sanitycheck: fix FileNotFoundError #30277
Conversation
github-actions
bot
added
the
area: Sanitycheck
wangnuannuan
force-pushed
the
jingru-fix-FileNotFoundError
branch
from
142b159 to
5ce47ff
Compare
scripts/sanity_chk/sanitylib.py
Outdated
| os.kill(pid, signal.SIGTERM) | ||
| except ProcessLookupError: | ||
| pass | ||
| if os.path.exists(self.pid_fn): |
There was a problem hiding this comment.
put both in one single if statement.
When platform is nsim_hs_smp, if testcase timeout, the sanitycheck may not be able to find mdb.pid Signed-off-by: Jingru Wang <[email protected]>
wangnuannuan
force-pushed
the
jingru-fix-FileNotFoundError
branch
from
5ce47ff to
16e8df8
Compare
There was a problem hiding this comment.
First of all it looks like it might be at attempt to fix the same problem as here #30301. And from @evgeniy-paltsev explanation I'd say it's quite a reverse situation: not test time-outs and then we cannot find a PID of some process, but we execute a test that fast that child process' PID is no longer available.
Anyways that kind of justification makes IMHO no sense:
if testcase timeout, the sanitycheck may not be able to find mdb.pid
What we want to see is analysis of what was wrong in the first place and only then suggest a fix for the real root cause. Otherwise we're trying to cure a symptom which most probably will hide the real problem deeper and it will inevitably hit us later but at a larger scale.
nashif
added
area: Twister
|
stale |
When platform is nsim_hs_smp, if testcase timeout, the sanitycheck may not be able to find mdb.pid
#30276
Signed-off-by: Jingru Wang [email protected]