-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes CMSIS v2 test on x86 #30621
Fixes CMSIS v2 test on x86 #30621
Conversation
@dcpleung this hangs for me on
|
I'm almost sure it does fix it, which was my point: if my PR gets merged first then this PR needs rebasing, and if this PR gets merged first then I need to update my PR to not try to add anything to the excludes. |
Hm... ran a couple times on my boards back-to-back without any issues. Let me try run it more times and see if I can reproduce this. |
Ran 15 times back-to-back without hanging but I had |
Found the issue with hanging under |
In test_event_flags_no_wait_timeout(), after creating thread1, there is a little delay to let it run to trigger FLAG1. However, in test_event_flags_signalled(), this is not being done, and on some platforms it triggers the assert in thread1() complaining the flag not being set. This adds the same delay in test_event_flags_signalled() and the this test passes for those previously failed platforms. Signed-off-by: Daniel Leung <[email protected]>
Some of the thread tests are hard-coded with assumption that there is only one CPU. So limit the number of CPUs to 1 via kconfig. Signed-off-by: Daniel Leung <[email protected]>
The conditions which prohibit running the test suite on qemu_x86_64, up_squared and ehl_crb no longer exist. So remove these two from the exclude list, and now they can be built and run in CI. Signed-off-by: Daniel Leung <[email protected]>
89c456d
to
6163605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and it fixed 25507
Fixes #25507