-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert PRs #31115 and #31224 #31437
Closed
Closed
Revert PRs #31115 and #31224 #31437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following projects have a revision update in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
This reverts commit 2674828. Signed-off-by: Peter Bigot <[email protected]>
This reverts commit 6d3cdf5. Signed-off-by: Peter Bigot <[email protected]>
This reverts commit 5548917. Signed-off-by: Peter Bigot <[email protected]>
This reverts commit 9f1ea0f. Signed-off-by: Peter Bigot <[email protected]>
This reverts commit b0ec7a6. Signed-off-by: Peter Bigot <[email protected]>
…files" This reverts commit dbf9d99. Signed-off-by: Peter Bigot <[email protected]>
This reverts commit 251648a. Signed-off-by: Peter Bigot <[email protected]>
not fixed after all |
57dbaeb
to
b03bced
Compare
carlescufi
requested changes
Jan 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was fixed by #31446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: API
Changes to public APIs
area: Boards
area: Modules
area: Samples
Samples
manifest
manifest-hal_nordic
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
251648a seems to have broken compliance due to some problem in the Nordic HAL repository.
This commit fixes it by reverting first #31115, which also updated the Nordic repository, then reverting #31224 which introduced the problem.
Fixes #31436