Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PRs #31115 and #31224 #31437

Closed
wants to merge 7 commits into from

Conversation

pabigot
Copy link
Collaborator

@pabigot pabigot commented Jan 19, 2021

251648a seems to have broken compliance due to some problem in the Nordic HAL repository.

This commit fixes it by reverting first #31115, which also updated the Nordic repository, then reverting #31224 which introduced the problem.

Fixes #31436

@github-actions
Copy link

github-actions bot commented Jan 19, 2021

The following projects have a revision update in this Pull Request:

Name Old Revision New Revision
hal_nordic zephyrproject-rtos/hal_nordic@74e4ab0 zephyrproject-rtos/hal_nordic@8e132fe

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@pabigot pabigot requested review from anangl and carlescufi January 19, 2021 21:30
@pabigot pabigot closed this Jan 19, 2021
@pabigot
Copy link
Collaborator Author

pabigot commented Jan 19, 2021

not fixed after all

@pabigot pabigot changed the title Revert "modules: Move nrfx glue code to main Zephyr repository" Revert PRs #31115 and #31224 Jan 19, 2021
Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed by #31446

@pabigot pabigot closed this Jan 20, 2021
@pabigot pabigot deleted the nordic/20210119a branch January 22, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compliance script broken
2 participants