-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: coap: Fixed discovery response formatting according to RFC6690 #31610
Conversation
ca0a0ee
to
a688863
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one nit. Thanks for addressing this issue!
Please, no merge commits in PRs. Just rebase your stuff against latest master and force push to this PR. |
I will rebase and push. |
CoAP RFC (RFC7252) states that end points should support the CoRE Link Format of discoverable resources as described in RFC6690 (refer section 7.2 of the RFC7252). Fixes zephyrproject-rtos#31609 Signed-off-by: Kasun Hewage <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Lookd like only the build 14 was failed. Any idea? |
This PR resolves #31609
Signed-off-by: Kasun Hewage [email protected]