Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: coap: Fixed discovery response formatting according to RFC6690 #31610

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

kasunch
Copy link
Contributor

@kasunch kasunch commented Jan 26, 2021

This PR resolves #31609

Signed-off-by: Kasun Hewage [email protected]

@kasunch kasunch requested a review from rlubos as a code owner January 26, 2021 08:59
@kasunch kasunch force-pushed the rfc6690_fix branch 2 times, most recently from ca0a0ee to a688863 Compare January 26, 2021 09:29
@kasunch kasunch changed the title CoAP discovery response does not follow CoRE link format specification net: coap: Fixed discovery response formatting according to RFC6690 Jan 26, 2021
@nashif nashif requested a review from jukkar January 26, 2021 11:30
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one nit. Thanks for addressing this issue!

subsys/net/lib/coap/coap_link_format.c Outdated Show resolved Hide resolved
@jukkar
Copy link
Member

jukkar commented Jan 26, 2021

Please, no merge commits in PRs. Just rebase your stuff against latest master and force push to this PR.

@kasunch
Copy link
Contributor Author

kasunch commented Jan 26, 2021

I will rebase and push.

CoAP RFC (RFC7252) states that end points should support
the CoRE Link Format of discoverable resources as described in RFC6690
(refer section 7.2 of the RFC7252).

Fixes zephyrproject-rtos#31609

Signed-off-by: Kasun Hewage <[email protected]>
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasunch
Copy link
Contributor Author

kasunch commented Jan 27, 2021

Lookd like only the build 14 was failed. Any idea?

@nashif nashif merged commit 7dad856 into zephyrproject-rtos:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoAP discovery response does not follow CoRE link format specification
4 participants