Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/drivers: pwm_api: Document how to tune test for stm32 targets #31612

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

erwango
Copy link
Member

@erwango erwango commented Jan 26, 2021

The way the test is implemented requires some adaptation to
be effective on all STM32 boards.
I'm not adding per board code on purpose, as this would be a
never ending story.

Fixes #31582

Signed-off-by: Erwan Gouriou [email protected]

@erwango erwango requested a review from nashif as a code owner January 26, 2021 10:39
@erwango erwango self-assigned this Jan 26, 2021
@github-actions github-actions bot added the area: Tests Issues related to a particular existing or missing test label Jan 26, 2021
@zephyrbot zephyrbot added the area: PWM Pulse Width Modulation label Jan 26, 2021
The way the test is implemented requires some adaptation to
be effective on all STM32 boards.
I'm not adding per board code on purpose, as this would be a
never ending story.

Fixes zephyrproject-rtos#31582

Signed-off-by: Erwan Gouriou <[email protected]>
@@ -76,6 +76,15 @@
#elif defined CONFIG_BOARD_ADAFRUIT_ITSYBITSY_M4_EXPRESS
#define DEFAULT_PWM_PORT 2 /* TCC1/WO[2] on PA18 (D7) */
#elif DT_HAS_COMPAT_STATUS_OKAY(st_stm32_pwm)
/* Default port should be adapted per board to fit the channel
* associated to the PWM pin. For intsance, for following device,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: intsance

@ioannisg ioannisg merged commit 3d267ee into zephyrproject-rtos:master Jan 26, 2021
@erwango erwango deleted the fix_pwm_test branch January 27, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: PWM Pulse Width Modulation area: Tests Issues related to a particular existing or missing test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STM32F746ZG: No pwm signal output when running /tests/drivers/pwm/pwm_api
6 participants