[RFC] SOF: cAVS 1.5 needs reset-vector.S in the main image #31751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgirdwood
approved these changes
Jan 29, 2021
KangJianX
reviewed
Feb 1, 2021
| @@ -6,3 +6,4 @@ CONFIG_LP_MEMORY_BANKS=2 | |||
| CONFIG_HP_MEMORY_BANKS=8 | |||
| CONFIG_PERFORMANCE_COUNTERS=y | |||
| CONFIG_COMP_SRC_SMALL=y | |||
| CONFIG_RESET_VECTOR_IN_BOOTLOADER=n | |||
There was a problem hiding this comment.
I think add this configuration to common config is better than samples(like boards/xtensa/intel_adsp_cavs15/intel_adsp_cavs15_defconfig)
There was a problem hiding this comment.
@KangJianX that doesn't work because then it's overwritten by samples/audio/sof/prj.conf. What we could do though is remove that setting from prj.conf and specify it in each boards/xtensa/intel_adsp_cavs*/intel_adsp_cavs*_defconfig individually where we need the non-default value. Would that be better?
APL ADSP doesn't boot with reset-vector.S in the bootloader, move it over to the main application binary. Signed-off-by: Guennadi Liakhovetski <[email protected]>
dcpleung
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APL ADSP doesn't boot with reset-vector.S in the bootloader, move it over to the main application binary.
In fact this is rather a guessed work-around than a proper solution. I haven't been able to figure out why this is required. Why on CNL the reset vector code can be either in the bootloader or in the main image, but on APL it only works when in the main image. But without this patch APL is broken. This might as well help with #31735 but it would certainly be great to understand the reason.
Another possibility could be to switch all Xtensa builds to unconditionally link reset-vector.S in the main image. This would however then differ from the way SOF is currently linked.