Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dma: stm32: remove dump stream info in irq #32008

Merged
merged 1 commit into from
Feb 5, 2021
Merged

dma: stm32: remove dump stream info in irq #32008

merged 1 commit into from
Feb 5, 2021

Conversation

shlomow
Copy link
Contributor

@shlomow shlomow commented Feb 4, 2021 •
edited by erwango
Loading

Remove printing dma stream info in irq context.
This is printed in case of error.

Signed-off-by: Shlomi Vaknin [email protected]

Fixes: #32030

@shlomow
dma: stm32: remove dump stream info in irq
35218ae 
Remove printing dma stream info in irq context.
This is printed in case of error.

Signed-off-by: Shlomi Vaknin <[email protected]>
@github-actions github-actions bot added the platform: STM32 ST Micro STM32 label Feb 4, 2021
@shlomow shlomow mentioned this pull request Feb 4, 2021
Merged
@erwango erwango requested review from ABOSTM and FRASTM February 5, 2021 09:38
@erwango erwango added this to the v2.5.0 milestone Feb 5, 2021
@erwango erwango added area: DMA Direct Memory Access bug The issue is a bug, or the PR is fixing a bug labels Feb 5, 2021
@FRASTM
Copy link
Collaborator

FRASTM commented Feb 5, 2021

Note that in the irq, the dma_stm32_dump_stream_irq also comes in the case of Unexpected irq happened and Transfer Error.
And in dma_stm32_V1.c the stm32_dma_is_unexpected_irq_happened also has its dma_stm32_dump_stream_irq
-->It is really needed ?

@erwango erwango requested a review from nashif February 5, 2021 16:49
@erwango erwango added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Feb 5, 2021
ABOSTM
ABOSTM approved these changes Feb 5, 2021
View reviewed changes
Copy link
Collaborator

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nashif nashif merged commit 5ccb89c into zephyrproject-rtos:master Feb 5, 2021
@shlomow shlomow deleted the st-dma-remove-dump branch February 5, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwango erwango erwango approved these changes

@ABOSTM ABOSTM ABOSTM approved these changes

@cybertale cybertale Awaiting requested review from cybertale

@lowlander lowlander Awaiting requested review from lowlander

@FRASTM FRASTM Awaiting requested review from FRASTM

@nashif nashif Awaiting requested review from nashif

Assignees

@erwango erwango

Labels
area: DMA Direct Memory Access bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

dma: stm32: remove dump stream info in irq
5 participants
@shlomow @FRASTM @erwango @ABOSTM @nashif