bluetooth: controller: Extend DTM commands #42300

KAGA164 · 2022-01-31T07:51:26Z

This PR adds a support for following HCI commands:

HCI LE Receiver Test [v3]
HCI LE Transmitter Test [v3]
HCI LE Transmitter Test [v4]

Those command set add a possibility to test the radio CTE reception and transmission. The HCI LE Transmitter Test v4 commands allows setting a transmit power. The Controller under the DTM test can also generate the HCI Connectionless IQ Report event when it receives the CTE.

cvinayak · 2022-02-01T06:10:26Z

samples/bluetooth/hci_uart/sample.yaml

+    platform_allow: nrf52833dk_nrf52833
+    extra_configs:
+      - CONFIG_BT_CTLR_DF=y
+      - CONFIG_BT_CTLR_DTM_HCI_DF_IQ_REPORT=y"


Suggested change

- CONFIG_BT_CTLR_DTM_HCI_DF_IQ_REPORT=y"

- CONFIG_BT_CTLR_DTM_HCI_DF_IQ_REPORT=y

subsys/bluetooth/controller/Kconfig.dtm

cvinayak · 2022-02-01T06:27:10Z

subsys/bluetooth/controller/hci/hci.c

+#if defined(CONFIG_BT_CTLR_DF_SCAN_CTE_RX)
+	if (lll && ull_df_sync_cfg_is_not_enabled(&lll->df_cfg)) {
+		/* Drop further processing of the event. */


Heads up, will conflict with #42302

Thanks. Resloved

cvinayak · 2022-02-01T06:33:11Z

subsys/bluetooth/controller/ll_sw/nordic/lll/lll_test.c

+#endif /* CONFIG_BT_CTLR_DF_CTE_RX */
+
+#if defined(CONFIG_BT_CTLR_DTM_HCI_DF_IQ_REPORT)
+static void create_iq_report(bool crc_ok)


Suggested change

static void create_iq_report(bool crc_ok)

static int create_iq_report(bool crc_ok)

cvinayak · 2022-02-01T06:54:32Z

subsys/bluetooth/controller/ll_sw/nordic/lll/lll_test.c

+	uint32_t start_us;
+	uint32_t err;
+	bool cte_request = (cte_len > 0) ? 1 : 0;


Suggested change

uint32_t start_us;

uint32_t err;

bool cte_request = (cte_len > 0) ? 1 : 0;

const bool cte_request = (cte_len > 0) ? 1 : 0;

uint32_t start_us;

uint8_t err;

cvinayak · 2022-02-01T06:56:18Z

subsys/bluetooth/controller/ll_sw/nordic/lll/lll_test.c

@@ -193,74 +499,119 @@ static uint32_t init(uint8_t chan, uint8_t phy, void (*isr)(void *))
 	/* NOTE: No whitening in test mode. */
 	radio_phy_set(test_phy, test_phy_flags);
 	radio_tmr_tifs_set(150);
-	radio_tx_power_max_set();
+
+	err = tx_power_set(tx_power);


declare a local uint8_t ret;

Suggested change

err = tx_power_set(tx_power);

ret = tx_power_set(tx_power);

cvinayak · 2022-02-01T06:56:34Z

subsys/bluetooth/controller/ll_sw/nordic/lll/lll_test.c

+			    RADIO_PKT_CONF_CTE(cte ? RADIO_PKT_CONF_CTE_ENABLED :
+						     RADIO_PKT_CONF_CTE_DISABLED));
+
+	return err;


Suggested change

return err;

return ret;

subsys/bluetooth/controller/ll_sw/nordic/lll/lll_test.c

include/bluetooth/hci.h

subsys/bluetooth/controller/Kconfig.dtm

subsys/bluetooth/controller/hci/hci.c

subsys/bluetooth/controller/ll_sw/nordic/lll/lll_test.c

samples/bluetooth/hci_uart/boards/nrf52833dk_nrf52833.overlay

ppryga-nordic

One new comment added.
Please go through unresolved comments from previous review also.

subsys/bluetooth/controller/hci/hci.c

KAGA164 · 2022-03-03T09:47:23Z

@ppryga @cvinayak any comments ? Are we ready to merge it ?

samples/bluetooth/hci_uart/boards/nrf52833dk_nrf52833.overlay

ppryga-nordic · 2022-03-07T08:46:36Z

subsys/bluetooth/shell/ll.c

@@ -69,7 +69,7 @@ int cmd_test_tx(const struct shell *sh, size_t  argc, char *argv[])
 	type = strtoul(argv[3], NULL, 16);
 	phy  = strtoul(argv[4], NULL, 16);

-	err = ll_test_tx(chan, len, type, phy);
+	err = ll_test_tx(chan, len, type, phy, 0, 0, 0, NULL, 0x7F);


Didn't you forget about this?

ppryga-nordic · 2022-03-07T08:46:39Z

subsys/bluetooth/shell/ll.c

@@ -92,7 +92,7 @@ int cmd_test_rx(const struct shell *sh, size_t  argc, char *argv[])
 	phy     = strtoul(argv[2], NULL, 16);
 	mod_idx = strtoul(argv[3], NULL, 16);

-	err = ll_test_rx(chan, phy, mod_idx);
+	err = ll_test_rx(chan, phy, mod_idx, 0, 0, 0, 0, NULL);


Didn't you forget about this?

subsys/bluetooth/controller/ll_sw/nordic/lll/lll_test.c

KAGA164 · 2022-03-07T11:02:56Z

@ppryga I replaced magic number in shell related files and also I added a doc entry about the Direction Finding in hci_uart sample doc.

samples/bluetooth/hci_uart/README.rst

ppryga-nordic · 2022-03-07T16:29:32Z

Approved in regard of changes I've requested.

cvinayak

Since you would be testing DTM, this is a request to include related suggestion mentioned here: #42866 (comment)

subsys/bluetooth/controller/Kconfig.dtm

KAGA164 · 2022-03-17T13:09:48Z

I added DNM. I just want to check one more thing

This adds support for the following Direct Test mode commands: - HCI LE Receiver Test [v3] - HCI LE Transmitter Test [v3] - HCI LE Transmitter Test [v4] Those commands set add a possibility to test an CTE reception and transmission. The HCI LE Transmitter Test [v4] commands allows also setting a transmit power. Signed-off-by: Kamil Gawor <[email protected]>

Alignes the Openisa ll_test_tx and ll_test_rx functions with the new test API. Signed-off-by: Kamil Gawor <[email protected]>

Adds support for the nrf52833dk_nrf52833 which supports the Direction Finding feature. It allows also to perform the Direct Test Mode with the CTE feature. Signed-off-by: Kamil Gawor <[email protected]>

Adds antenna description for the nrf5340dk_nrf5340_cpunet target. It allows to performthe Direct Test Mode with the CTE feature on this target. Signed-off-by: Kamil Gawor <[email protected]>

Add the Direction Finding documentation section into the sample README.rst file. Signed-off-by: Kamil Gawor <[email protected]>

KAGA164 · 2022-03-17T14:58:28Z

@ppryga @cvinayak I needed to rebase due to the API changed for:
void radio_df_cte_rx_2us_switching(bool cte_info_in_s1, uint8_t phy); and
void radio_df_cte_rx_4us_switching(bool cte_info_in_s1, uint8_t phy)

ppryga-nordic

Quick look - ACK

KAGA164 requested review from alwa-nordic, carlescufi, cvinayak, jhedberg, kruithofa, thoh-ot and Vudentz as code owners January 31, 2022 07:51

github-actions bot added area: API Changes to public APIs area: Bluetooth area: Bluetooth Controller area: Samples Samples labels Jan 31, 2022

KAGA164 requested a review from ppryga-nordic January 31, 2022 07:51

cvinayak requested changes Feb 1, 2022

View reviewed changes

cvinayak self-assigned this Feb 1, 2022

ppryga-nordic requested changes Feb 1, 2022

View reviewed changes

ppryga-nordic reviewed Feb 1, 2022

View reviewed changes

samples/bluetooth/hci_uart/boards/nrf52833dk_nrf52833.overlay Show resolved Hide resolved

cvinayak mentioned this pull request Feb 9, 2022

BLE Testing functions do not work properly #42534

Closed

KAGA164 force-pushed the dtm_add_support_for_cte branch from 7b549b2 to bed66fb Compare February 9, 2022 15:20

KAGA164 requested review from ppryga-nordic and cvinayak February 9, 2022 15:38

ppryga-nordic requested changes Feb 22, 2022

View reviewed changes

subsys/bluetooth/controller/hci/hci.c Outdated Show resolved Hide resolved

KAGA164 force-pushed the dtm_add_support_for_cte branch from bed66fb to 4700bfa Compare February 23, 2022 11:10

KAGA164 requested a review from ppryga-nordic February 23, 2022 11:48

KAGA164 force-pushed the dtm_add_support_for_cte branch from 4700bfa to 1c0bffb Compare February 25, 2022 15:33

alwa-nordic removed their request for review February 28, 2022 16:55

ppryga-nordic requested changes Mar 7, 2022

View reviewed changes

KAGA164 force-pushed the dtm_add_support_for_cte branch from 1c0bffb to 58506d1 Compare March 7, 2022 11:01

KAGA164 requested a review from nashif as a code owner March 7, 2022 11:01

github-actions bot added the area: Documentation label Mar 7, 2022

ppryga-nordic requested changes Mar 7, 2022

View reviewed changes

samples/bluetooth/hci_uart/README.rst Show resolved Hide resolved

KAGA164 force-pushed the dtm_add_support_for_cte branch from 58506d1 to 66a693c Compare March 7, 2022 14:22

ppryga-nordic previously approved these changes Mar 7, 2022

View reviewed changes

cvinayak requested changes Mar 17, 2022

View reviewed changes

subsys/bluetooth/controller/Kconfig.dtm Show resolved Hide resolved

cvinayak previously approved these changes Mar 17, 2022

View reviewed changes

KAGA164 added the DNM This PR should not be merged (Do Not Merge) label Mar 17, 2022

KAGA164 added 5 commits March 17, 2022 15:53

bluetooth: controller: Align the Openisa test ll API

3109b17

Alignes the Openisa ll_test_tx and ll_test_rx functions with the new test API. Signed-off-by: Kamil Gawor <[email protected]>

bluetooth: samples: hci_uart: Add support for nrf52833dk

68240a0

Adds support for the nrf52833dk_nrf52833 which supports the Direction Finding feature. It allows also to perform the Direct Test Mode with the CTE feature. Signed-off-by: Kamil Gawor <[email protected]>

bluetooth: samples: hci_uart: Add nrf5340 antenna description

170f9fb

Adds antenna description for the nrf5340dk_nrf5340_cpunet target. It allows to performthe Direct Test Mode with the CTE feature on this target. Signed-off-by: Kamil Gawor <[email protected]>

bluetooth: samples: hci_uart: Add Direction Finding doc

72e89fe

Add the Direction Finding documentation section into the sample README.rst file. Signed-off-by: Kamil Gawor <[email protected]>

KAGA164 dismissed stale reviews from cvinayak and ppryga-nordic via 72e89fe March 17, 2022 14:55

KAGA164 force-pushed the dtm_add_support_for_cte branch from 66a693c to 72e89fe Compare March 17, 2022 14:55

cvinayak approved these changes Mar 18, 2022

View reviewed changes

ppryga-nordic approved these changes Mar 18, 2022

View reviewed changes

carlescufi merged commit 3e9dfdd into zephyrproject-rtos:main Mar 18, 2022

KAGA164 mentioned this pull request Apr 6, 2022

Bluetooth: Controller: DTM: Fix timer rollover #42866

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bluetooth: controller: Extend DTM commands #42300

bluetooth: controller: Extend DTM commands #42300

KAGA164 commented Jan 31, 2022 •

edited

Loading

cvinayak Feb 1, 2022

KAGA164 Feb 9, 2022

cvinayak Feb 1, 2022

KAGA164 Feb 9, 2022

cvinayak Feb 1, 2022

KAGA164 Feb 9, 2022

cvinayak Feb 1, 2022

KAGA164 Feb 9, 2022

cvinayak Feb 1, 2022

KAGA164 Feb 9, 2022

cvinayak Feb 1, 2022

ppryga-nordic left a comment

KAGA164 commented Mar 3, 2022

ppryga-nordic Mar 7, 2022

ppryga-nordic Mar 7, 2022

KAGA164 commented Mar 7, 2022

ppryga-nordic commented Mar 7, 2022

cvinayak left a comment

KAGA164 commented Mar 17, 2022

KAGA164 commented Mar 17, 2022

ppryga-nordic left a comment

	- CONFIG_BT_CTLR_DTM_HCI_DF_IQ_REPORT=y"
	- CONFIG_BT_CTLR_DTM_HCI_DF_IQ_REPORT=y

	static void create_iq_report(bool crc_ok)
	static int create_iq_report(bool crc_ok)

bluetooth: controller: Extend DTM commands #42300

bluetooth: controller: Extend DTM commands #42300

Conversation

KAGA164 commented Jan 31, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ppryga-nordic left a comment

Choose a reason for hiding this comment

KAGA164 commented Mar 3, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KAGA164 commented Mar 7, 2022

ppryga-nordic commented Mar 7, 2022

cvinayak left a comment

Choose a reason for hiding this comment

KAGA164 commented Mar 17, 2022

KAGA164 commented Mar 17, 2022

ppryga-nordic left a comment

Choose a reason for hiding this comment

KAGA164 commented Jan 31, 2022 •

edited

Loading