Bluetooth: Controller: Fix timings for Tx test #44735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KAGA164
requested review from
carlescufi,
cvinayak,
thoh-ot and
kruithofa
as code owners
cvinayak
requested changes
Apr 11, 2022
Comment on lines
642
to
640
| /* Set the initial value of the TIFS. It will be tuned up after | ||
| * the first packet transmission. | ||
| */ | ||
| radio_tmr_tifs_set(SCAN_INT_UNIT_US); | ||
| radio_switch_complete_and_b2b_tx(test_phy, test_phy_flags, test_phy, test_phy_flags); | ||
|
|
There was a problem hiding this comment.
The second PDU will not be at a multiple of 625us slot, this is not correct.
Instead modify calculate_tifs() to calculate the tIFS using the PDU length and PHY used, use it here and in isr_tx so that first and consecutive PDUs will all be at 625us slot multiples.
There was a problem hiding this comment.
Discussed offline. The tifs is calculated manually at the beginning of the Tx test now
cvinayak
previously approved these changes
Apr 11, 2022
grochu
reviewed
Apr 11, 2022
| transmit_time = PDU_US(len, 0, test_phy, test_phy_flags); | ||
| #endif /* CONFIG_BT_CTLR_DF_CTE_TX */ | ||
|
|
||
| interval = ceiling_fraction((transmit_time + 249), SCAN_INT_UNIT_US) * SCAN_INT_UNIT_US; |
There was a problem hiding this comment.
It would be good to document the magic number, though I know it comes from the original code.
There was a problem hiding this comment.
I like this idea. Done
cvinayak
changed the title
The Tx interval is now calculated at the beginning of the Tx test and the next transmission is triggerd by the switch timer instead of event timer. This fixes a corner case issue when timer rollover. Signed-off-by: Kamil Gawor <[email protected]>
grochu
approved these changes
Apr 13, 2022
cvinayak
approved these changes
Apr 13, 2022
carlescufi
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tx interval is now calculated once per each
Tx test and the next transmission is triggerd by
the switch timer instead of event timer. This
fixes a corner case issue when timer rollover.
Fixes: #42534.