drivers: stm32l5 FMC LCD display driver #45654
Conversation
Driver implementation for st7789h2 display controller using the STM32 series FMC peripheral for driving the parallel bus interface. Signed-off-by: Jeremy LOCHE <[email protected]>
Enable the color display for STM32L562E_DK board. The driver is using the FMC peripheral to drive the bus. The power supply to the LCD is handled by the regulator driver at startup. Signed-off-by: Jeremy LOCHE <[email protected]>
github-actions
bot
added
area: Boards
area: Devicetree
area: Devicetree Binding
| reg = <0x60000000 | ||
| 0x60000002>; | ||
|
|
||
| compatible = "sitronix,st7789h2-st-fmc"; |
There was a problem hiding this comment.
@lochej That's a great work, but wouldn't it be possible to push this one step further and completely split st7792h2 driver from STM32 FMC ?
There was a problem hiding this comment.
@erwango thank you :-) in fact I wasn't 100% sure on how to implement the memory mapped access. As a first step, I used the reg=<> property to give the absolute addresses.
In a sense, if some other devices could drive an LCD thourgh direct memory write, then this driver will work, it doesn't have to be under a FMC bank node.
Though regarding init priorities, I've put the LCD device tree definition under its bank parent so I'm sure the bank was init before its LCD child.
There was a problem hiding this comment.
Agreed, I had a similar complaint when a panel driver was introduced with vendor dependent MIPI-DSI code inside. Fortunately it lead to the experimental MIPI-DSI interface, so that panel drivers stay vendor independent. Something similar should be done here.
There was a problem hiding this comment.
Great, I'd love to go in this direction. Could you help me find out how the splitting should be done ?
My driver implementation doesn't use any FMC vendor specific code, it just writes at a given address pointer in the reg properties.
So implementation wise, it is more or less split from the FMC driver (except from the name ?).
Are there any ideas for improving that ? Creating an a memory bus interface/driver that could be parallel bitbang or through FMC or anything else ?
| reg = <0x60000000 | ||
| 0x60000002>; | ||
|
|
||
| compatible = "sitronix,st7789h2-st-fmc"; |
There was a problem hiding this comment.
Agreed, I had a similar complaint when a panel driver was introduced with vendor dependent MIPI-DSI code inside. Fortunately it lead to the experimental MIPI-DSI interface, so that panel drivers stay vendor independent. Something similar should be done here.
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Fixes #39289
Improvement to PR #39335 now that #44448 has been merged.
Adds support for STM32L562E-DK driver TFT color display based on the ST7789H2 driver.
The implementation uses the FMC peripheral to drive the ST7789H2 with a 16bit parallel interface.
Initial support added to STM32L562E_DK board.