samples/bluetooth/hci_uart: Add support for USB CDC UART. #50453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmo
requested review from
nashif,
jhedberg,
Vudentz,
alwa-nordic and
sjanc
as code owners
zephyrbot
requested review from
asbjornsabo,
hermabe,
jori-nordic and
Thalley
jori-nordic
previously approved these changes
Sep 21, 2022
There was a problem hiding this comment.
I think board configuration is fine, I've done it before for an out-of-tree sample (LLPM) for the same reasons.
jhedberg
previously approved these changes
Sep 21, 2022
alwa-nordic
previously approved these changes
Sep 21, 2022
This PR adds support using the USB CDC UART in the hci_uart sample, including sample configuration for the nRF 52840 dongle. Signed-off-by: Jim Mussared <[email protected]>
jimmo
dismissed stale reviews from alwa-nordic, jhedberg, and jori-nordic
via
0e86753
jimmo
force-pushed
the
hci-uart-usb-cdc
branch
from
4eaa64e to
0e86753
Compare
jhedberg
approved these changes
Sep 27, 2022
alwa-nordic
approved these changes
Sep 27, 2022
jori-nordic
approved these changes
Sep 27, 2022
carlescufi
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hci_uartexample is really useful, but occasionally I have a need to use it over a USB UART.This PR adds support for this, including sample configuration for the nRF 52840 dongle.
I'm not sure if providing a specific board configuration is the right way to do this though, would welcome advice!