Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch to CI image 0.24.10 #54626

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

stephanosio
Copy link
Member

This commit updates the CI workflows to use the CI image 0.24.10, in order to pull in a more recent version of BabbleSim (v1.1.1) and an additional thrift-compiler dependency for the Apache Thrift module.

Signed-off-by: Stephanos Ioannidis [email protected]


Tested in https://github.com/zephyrproject-rtos/zephyr-testing/actions/runs/4125732751/jobs/7126862260

This commit updates the CI workflows to use the CI image 0.24.10, in
order to pull in a more recent version of BabbleSim (v1.1.1) and an
additional thrift-compiler dependency for the Apache Thrift module.

Signed-off-by: Stephanos Ioannidis <[email protected]>
@cfriedt
Copy link
Member

cfriedt commented Feb 8, 2023

Edited (just saw the link above pointing to a successful test run, which answers my previous question)

@cfriedt
Copy link
Member

cfriedt commented Feb 9, 2023

/me wants to press rebase and merge @stephanosio

@stephanosio
Copy link
Member Author

Edited (just saw the link above pointing to a successful test run, which answers my previous question)

Twister run passed, but the Bluetooth test run is currently failing (likely because of the BabbleSim update).

I have pinged #bluetooth on Discord and am currently waiting for an answer on this.

@nashif
Copy link
Member

nashif commented Feb 9, 2023

/me wants to press rebase and merge @stephanosio

why is this needed before the release?

@nashif
Copy link
Member

nashif commented Feb 9, 2023

oh thrift, so we have never ran those tests/samples in CI?

@stephanosio
Copy link
Member Author

why is this needed before the release?

Mainly because of the Thrift module PR (note that this new image includes thrift-compiler).

@stephanosio
Copy link
Member Author

oh thrift, so we have never ran those tests/samples in CI?

The PR has not been merged yet: #54013

@stephanosio
Copy link
Member Author

Edited (just saw the link above pointing to a successful test run, which answers my previous question)

Twister run passed, but the Bluetooth test run is currently failing (likely because of the BabbleSim update).

I have pinged #bluetooth on Discord and am currently waiting for an answer on this.

I just re-triggered the Bluetooth test and it passed now (I assume either a fix was merged or the failure was an intermittent one). Will merge this now.

@stephanosio stephanosio merged commit d56ed39 into zephyrproject-rtos:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants