Build system: disable OUTPUT_DISASSEMBLY by default
#61023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This on-by-default option takes the majority of "link" time. If people need the disassembly, they can turn it on. Incremental builds of the bluetooth tester app: ```bash west build -b nrf52840dk_nrf52840 zephyr/tests/bluetooth/shell touch zephyr/subsys/bluetooth/shell/bt.c time west build -b nrf52840dk_nrf52840 ``` Before: real 0m6,621s user 0m6,430s sys 0m0,175s After: real 0m1,011s user 0m0,840s sys 0m0,170s ```bash rm -rf build time west build -p -b nrf52840dk_nrf52840 zephyr/tests/bluetooth/shell ``` Before: real 0m9,726s user 0m11,735s sys 0m2,665s After: real 0m4,545s user 0m8,006s sys 0m2,723s Signed-off-by: Jonathan Rico <[email protected]>
|
This will save CI 💲💲💲 |
|
Build failure seems unrelated:
|
tejlmand
approved these changes
Aug 3, 2023
|
@tejlmand would you know where I can document that |
|
Wow, who knew... maybe in release notes? The other bit in the doc where this is mentioned is https://docs.zephyrproject.org/latest/develop/beyond-GSG.html#build-blinky "Other binary formats, disassembly, and map files may be present depending on your board." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This on-by-default option takes the majority of "link" time. If people need the disassembly, they can turn it on.
Incremental builds of the bluetooth tester app:
west build -b nrf52840dk_nrf52840 zephyr/tests/bluetooth/shell touch zephyr/subsys/bluetooth/shell/bt.c time west build -b nrf52840dk_nrf52840rm -rf build time west build -p -b nrf52840dk_nrf52840 zephyr/tests/bluetooth/shell