net: icmpv4: Drop ICMPv4 packet if ICMP header is NULL #6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukkar
requested changes
Feb 13, 2018
subsys/net/ip/ipv4.c
Outdated
| @@ -143,6 +143,11 @@ static inline enum net_verdict process_icmpv4_pkt(struct net_pkt *pkt, | |||
|
|
|||
| icmp_hdr = net_icmpv4_get_hdr(pkt, &hdr); | |||
|
|
|||
There was a problem hiding this comment.
Usually we do not have empty line after setting the var and then checking it, so you could remove this extra line here.
There was a problem hiding this comment.
Thanks for info. Updated patch pushed.
Codecov Report
@@ Coverage Diff @@
## master #6170 +/- ##
==========================================
- Coverage 52.86% 52.86% -0.01%
==========================================
Files 412 412
Lines 40284 40286 +2
Branches 7802 7803 +1
==========================================
Hits 21296 21296
- Misses 15773 15774 +1
- Partials 3215 3216 +1
Continue to review full report at Codecov.
|
rmstoi
force-pushed
the
icmpv4_drop_null_header
branch
from
79fa6b4 to
af91a54
Compare
|
Patch amended by removing empty line and pushed. |
This commit fixes the crash of echo_server from malformed ICMPv4 packet. Fixes zephyrproject-rtos#6081 Signed-off-by: Ruslan Mstoi <[email protected]>
jukkar
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the crash of echo_server from malformed ICMPv4 packet.
Fixes #6081
Signed-off-by: Ruslan Mstoi [email protected]