device: add braces around dev/dev_rw initializer #65912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobaltieri
commented
Nov 29, 2023
gmarull
previously approved these changes
Nov 29, 2023
fabiobaltieri
force-pushed
the
dev-rw-union
branch
from
5beeab0 to
530032f
Compare
|
dropped the init entry and inlined the whole initializer, fixed up a misaligned closing brace in the device one |
gmarull
previously approved these changes
Nov 29, 2023
The init_entry struct got modified to add a union with a non const dev pointer in afc5911. Some old compiler (such as GCC 4) seems to require a pair of brackets to correctly initialize the field in the union. Add those brackets to the initializers in device.h and init.h to maintain compatibility. Signed-off-by: Fabio Baltieri <[email protected]>
fabiobaltieri
force-pushed
the
dev-rw-union
branch
from
530032f to
cbd9a8a
Compare
|
no nevermind, that brace was in the right spot, put it back, sorry @gmarull :-) |
gmarull
approved these changes
Nov 29, 2023
|
We should have @marc-hb test this before merging. Adding DNM for now. |
marc-hb
added
bug
fabiobaltieri
added
Regression
Good stuff, yeah it was interesting. :-) Let me just add all the tags I can think of and merge... |
fabiobaltieri
merged commit 153f38a
into
zephyrproject-rtos:main
30 of 31 checks passed
|
Funny how this failure was re-introduced: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
The init_entry struct got modified to add a union with a non const dev pointer in afc5911. Some old compiler (such as GCC 4) seems to require a pair of brackets to correctly initialize the field in the union. Add those brackets to the initializers in device.h and init.h to maintain compatibility.