Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: release_process: drop the paragraph about release freeze #69695

Conversation

fabiobaltieri
Copy link
Member

Drop the stable API paragraph mentioning API and feature freeze for multiple release. This hasn't been done or considered for as long as I remember and I don't think any developer really wants this.


...unless I'm misinterpreting the meaning of it.

Drop the stable API paragraph mentioning API and feature freeze for
multiple release. This hasn't been done or considered for as long as I
remember and I don't think any developer really wants this.

Signed-off-by: Fabio Baltieri <[email protected]>
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Completely forgot about needing to address this.

@cfriedt
Copy link
Member

cfriedt commented Mar 1, 2024

I was also just reading that and wondered the same thing 😅

Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not following a documented ansd agreed upon guideline calls for actions and review of why it was not followed or what the issues are, just removing that from the docs is not going to solve any problems, it is hiding them.

@fabiobaltieri fabiobaltieri added area: Process Process Tracked by the process WG labels Mar 4, 2024
@fabiobaltieri
Copy link
Member Author

Sounds like this should go through the Process WG right?

@nashif
Copy link
Member

nashif commented Mar 4, 2024

btw, this was followed for LTS2 and for LTS3 we might now have had any controversial changes coming last minute (well, aparat from hwmv2 where some kind of 'exception' was made).

Sounds like this should go through the Process WG right?

sure, but what exactly are you proposing? Removing this guideline/rule basically means anyone can rewrite the zephyr kernel and how it works 2 days before LTS feature freeze and having some of the most basic APIs/ and the core of OS ship in a completeley unstable stable state, and it should be "okay". Is this what you want?

@fabiobaltieri
Copy link
Member Author

Removing this guideline/rule basically means anyone can rewrite the zephyr kernel and how it works 2 days before LTS feature freeze and having some of the most basic APIs/ and the core of OS ship in a completeley unstable stable state, and it should be "okay". Is this what you want?

The text mention freezing the API for two releases and kernel for one so the way I read it this would have prevented any stable API change from 3.5 and any kernel feature from 3.6, is that correct or am I misinterpreting it? It just does not seems like something we do.

@nashif
Copy link
Member

nashif commented Mar 4, 2024

The text mention freezing the API for two releases and kernel for one so the way I read it this would have prevented any stable API change from 3.5 and any kernel feature from 3.6, is that correct or am I misinterpreting it? It just does not seems like something we do.

ok, we can review the text and improve the language there, but I do not think dropping the section completely is something we want to do without any replacement/clarification...

@henrikbrixandersen
Copy link
Member

henrikbrixandersen commented Mar 4, 2024

The text mention freezing the API for two releases and kernel for one so the way I read it this would have prevented any stable API change from 3.5 and any kernel feature from 3.6, is that correct or am I misinterpreting it? It just does not seems like something we do.

I actually brought these exact paragraphs up at a release meeting at the beginning of the 3.6 development cycle.

It was my understanding, also from your comments back then @nashif, that these paragraphs were legacy and did not represent the current policy. I promised back then to bring it up to the process WG, but forgot all about it. My apologies.

It is my understanding, that if these had been followed for v3.6.0, lots of the proposed changes should have been postponed (and even HWMv2 shouldn't have gone in now).

@nashif
Copy link
Member

nashif commented Mar 4, 2024

It is my understanding, that if these had been followed for v3.6.0, lots of the proposed changes should have been postponed (and even HWMv2 shouldn't have gone in now).

beside hwmv2, which originally was supposed to follow this (in the original schedule from 2022) what stable kernel, base os did we break or completely overhaul?

@henrikbrixandersen
Copy link
Member

beside hwmv2, which originally was supposed to follow this (in the original schedule from 2022) what stable kernel, base os did we break or completely overhaul?

One of the paragraphs says:

All stable APIs need to be frozen 2 releases before an LTS. APIs can be extended with additional features, but the core implementation is not modified. This is valid for the following subsystems for example:

  • Device Drivers (i2c.h, spi.h)…
  • Kernel (k_*):
  • OS services (logging,debugging, ..)
  • DTS: API and bindings stability
  • Kconfig

As I read that, it basically means that our migration guides for v3.5.0 and v3.6.0 (2 releases before an LTS) should have been empty except for changes to unstable/experimental APIs? All other APIs should have been frozen except for API extensions.

@fabiobaltieri
Copy link
Member Author

From the process meeting (@nashif @fabiobaltieri and @kartben) the conseus seems to be that this could use some rewording while keeping the idea of blocking core changes in the last two releases as a guideline. I'll look into reworking this PR into a rewording.

@fabiobaltieri fabiobaltieri marked this pull request as draft March 18, 2024 17:21
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label May 18, 2024
@fabiobaltieri fabiobaltieri deleted the lts-forever-frozen branch May 18, 2024 00:42
@dleach02
Copy link
Member

can we move this out of the process working group project area or move it to done or something? Just trying to clean up the project area

@fabiobaltieri fabiobaltieri removed the Process Tracked by the process WG label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants