-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest: update cmsis-nn to v6.0.0 & tflite-micro #73995
Conversation
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Updating CMSIS-NN also requires updating |
Yes, I put the info on how those were obtain in the commit message such as here zephyrproject-rtos/tflite-micro@c331051 |
Tells me what was imported, but not how. Did you build some sample application which pulled down all the sources which were then copied, or did you manually find git commit hashes and download sources from Github? Where did the patch files come from? |
These are the same files that are pulled in as apart of the tflite-micro build process. For example you can find the kissfft within here which is downloaded, unzipped, and had the patch file applied Skimming through the folder... I noticed that if you update tflite-micro, it looks like flatbuffers will need to be updated along with the patch file applied They were all manually pulled down from the download links |
As something I just found digging though... it looks like they pull a specific 'hash' of cmsis-nn which is this https://github.com/tensorflow/tflite-micro/blob/71fba59b5bebfd64b48e167bfcb669fff568ec74/tensorflow/lite/micro/tools/make/ext_libs/cmsis_download.sh#L50 It only looks like that hash is 2 commits behind the v6.0.0, so it 'may' still work with the v6.0.0 As I typed this... I noticed those 2 commits are only updates to pdsc files :/ |
8def258
to
2722be0
Compare
Included the Actual branch this is pointing at: https://github.com/JordanYates/tflite-micro/commits/zephyr-v3.7/ |
2f1aad7
to
8963be4
Compare
looks like all the CI is passing now 👍 but I don't have admin rights to create a branch for |
Can we please get issues resolved before RC2 on Friday, this PR shall go in for 3.7 as per the TSC meeting today. |
43a7a31
to
89ca3a3
Compare
submanifests/optional.yaml
Outdated
@@ -46,7 +46,7 @@ manifest: | |||
groups: | |||
- optional | |||
- name: tflite-micro | |||
revision: 1a34dcab41e7e0e667db72d6a40999c1ec9c510c | |||
revision: /pull/6/head |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove leading slash /
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to e1eecbee18aa8f7f0ad7e90f8b335564eb52c13f please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on the reviews and updates in zephyrproject-rtos/tflite-micro#6,
the sha should be 48613f7ba1ffbda46ad771a77a35408f48f922e9 instead. (https://github.com/zephyrproject-rtos/tflite-micro’s zephyr
branch should be updated accordingly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
89ca3a3
to
118961f
Compare
Update cmsis-nn to version 6.0.0. Revision history can be found at: https://arm-software.github.io/CMSIS-NN/latest/rev_hist.html Signed-off-by: Jordan Yates <[email protected]>
Update `tflite-micro` to the latest version. Signed-off-by: Jordan Yates <[email protected]>
Add new sources for 4 bit function variants to build system. Signed-off-by: Jordan Yates <[email protected]>
Specify the missing filter dimension that was the reason for the v6.0.0 version bump. Signed-off-by: Jordan Yates <[email protected]>
Add `CONFIG_REQUIRES_FLOAT_PRINTF=y` to tflite-micro samples as in the past the module was using its own `printf` implementation, but now uses our logging infrastructure. Signed-off-by: Jordan Yates <[email protected]>
Update the version update and link to the changelog. Signed-off-by: Jordan Yates <[email protected]>
692b5a2
118961f
to
692b5a2
Compare
Update cmsis-nn to version 6.0.0.
Revision history can be found at:
https://arm-software.github.io/CMSIS-NN/latest/rev_hist.html
New upstream revision is the v6.0.0 release tag + module.yml ARM-software/CMSIS-NN@6982301