Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serial: bluetooth: Print warning once when ring buffer is full #77430

Merged
merged 1 commit into from
Aug 26, 2024
Merged

serial: bluetooth: Print warning once when ring buffer is full #77430

merged 1 commit into from
Aug 26, 2024

Conversation

dathpo
Copy link
Contributor

@dathpo dathpo commented Aug 22, 2024

When compiling with the default CONFIG_UART_LOG_LEVEL, which seems to be INF, I get endless Ring buffer full, discard prints on the console, which also seem to have jammed the BLE connection with my target due to the repeated BLE sends:
image

This change avoids cluttering the logging subsystem.

@dathpo dathpo marked this pull request as ready for review August 22, 2024 19:59
@zephyrbot zephyrbot added area: UART Universal Asynchronous Receiver-Transmitter size: XS A PR changing only a single line of code labels Aug 22, 2024
@zephyrbot zephyrbot requested a review from dcpleung August 22, 2024 19:59
Copy link
Member

@ubieda ubieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dcpleung
Copy link
Member

Please fix the compliance check error.

This avoids cluttering the logging subsystem.

Signed-off-by: David T. Pocock <[email protected]>
@dathpo
Copy link
Contributor Author

dathpo commented Aug 23, 2024

@dcpleung FYI all checks passed.

@nashif nashif merged commit b247580 into zephyrproject-rtos:main Aug 26, 2024
23 checks passed
Copy link

Hi @dathpo!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@dathpo dathpo deleted the uart-bt-wrn branch August 26, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UART Universal Asynchronous Receiver-Transmitter size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants