Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submanifests: optional: Bump nanopb to 0.4.9 #80555

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

pdgendt
Copy link
Collaborator

@pdgendt pdgendt commented Oct 29, 2024

Sync upstream and get the latest tagged version 0.4.9.

Sync upstream and get the latest tagged version 0.4.9.

Signed-off-by: Pieter De Gendt <[email protected]>
@pdgendt pdgendt mentioned this pull request Oct 29, 2024
28 tasks
@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Oct 29, 2024
@zephyrbot
Copy link
Collaborator

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nanopb zephyrproject-rtos/nanopb@4474bd3 zephyrproject-rtos/nanopb@98bf4db zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@dkalowsk dkalowsk added this to the v4.0.0 milestone Nov 4, 2024
@pdgendt pdgendt self-assigned this Nov 6, 2024
@mmahadevan108
Copy link
Collaborator

@nashif @carlescufi can you help review

@mmahadevan108
Copy link
Collaborator

@pdgendt , need an update to the release notes?

Add section for nanopb and upstream sync.

Signed-off-by: Pieter De Gendt <[email protected]>
nashif
nashif previously approved these changes Nov 8, 2024
@pdgendt
Copy link
Collaborator Author

pdgendt commented Nov 8, 2024

Added release note

@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Nov 8, 2024
@kartben
Copy link
Collaborator

kartben commented Nov 8, 2024

Isn't it a bit late to take module updates?

@dkalowsk
Copy link
Contributor

dkalowsk commented Nov 8, 2024

Isn't it a bit late to take module updates?

This was one of the concerns I had brought up in the last Release meeting. A few of our modules are needing updates and the maintainers are working on it, but the time lines are not lining up with the 4.0 release. I don't think we came to any final conclusion during that discussion. Likely want to have this discussion not on the PR though :-)

@mmahadevan108 mmahadevan108 merged commit 373ed89 into zephyrproject-rtos:main Nov 9, 2024
25 checks passed
@pdgendt pdgendt deleted the nanopb-bump-0.4.9 branch November 10, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manifest manifest-nanopb Release Notes To be mentioned in the release notes size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants