lib: os: p4wq: fix K_P4WQ_DELAYED_START mode #82551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the PRESTART thread state was removed, this changed the semantics of k_thread_start() when thread was created with a K_FOREVER timeout, suspended and then started with k_thread_start(). This sequence is used in p4wq to implement K_P4WQ_DELAYED_START (which again is needed by K_P4WQ_USER_CPU_MASK). With PRESTART removed, the following sequence: z_mark_thread_as_not_suspended(thread); k_thread_start(thread); .. no longer starts the thread. As a result, p4wq users like SOF multicore configurations, hit errors as p4wq threads never start. Fix the implementation by removing the calls to change thread suspended state explicitly, but rather rely on the new k_thread_create() and k_thread_start() semantics. Fixes: 7cdf405 ("kernel/sched: Eliminate PRESTART thread state") Signed-off-by: Kai Vehmanen <[email protected]>
|
@andyross @peter-mitsis Not sure if #81684 is better, but pushed this PR as a more immediate fix as SOF is fatally wounded after the PRESTART removal... Local test passes, a bigger test run ongoing at thesofproject/sof#9709 |
kv2019i
force-pushed
the
202412-p4wq-fix
branch
2 times, most recently
from
afc757e to
a8997cb
Compare
|
New version pushed:
|
|
Just to be That Guy: this does indicate that we have some incomplete test coverage of p4wq delayed start, forcing SOF to be the guinea pig. Wouldn't hurt to add a test case that exercises it in a way this would have broken. |
nashif
approved these changes
Dec 4, 2024
nashif
added
the
Trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the PRESTART thread state was removed, this changed the semantics
of k_thread_start() when thread was created with a K_FOREVER timeout,
suspended and then started with k_thread_start().
This sequence is used in p4wq to implement K_P4WQ_DELAYED_START
(which again is needed by K_P4WQ_USER_CPU_MASK).
With PRESTART removed, the following sequence:
z_mark_thread_as_not_suspended(thread);
k_thread_start(thread);
.. no longer starts the thread. As a result, p4wq users like SOF
multicore configurations, hit errors as p4wq threads never start.
Fix the implementation by removing the calls to change thread
suspended state explicitly, but rather rely on the new
k_thread_create() and k_thread_start() semantics.
Fixes: 7cdf405 ("kernel/sched: Eliminate PRESTART thread state")