boards: weact: Add support for WeAct STM32H5 Core Board #84180

magiczny-kacper · 2025-01-17T22:15:05Z

Low cost STM32H5 series development board with bare minimum to run the MCU

github-actions · 2025-01-17T22:15:43Z

Hello @magiczny-kacper, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

JarmouniA · 2025-01-18T14:39:11Z

Hi @magiczny-kacper, thanks for your contribution. Please see remarks in PR #84033 and apply the relevant ones here. Also squash the last 2 commits, and preferably put the SoC dtsi definition in a separate commit.

JarmouniA · 2025-01-18T17:19:50Z

@magiczny-kacper the 1st commit title should be dts: st: h5: add STM32H562xG SoC support

Added STM32H562xG dts file Signed-off-by: Kacper Brzostowski <[email protected]>

nordicjm · 2025-01-20T08:09:53Z

boards/weact/stm32h5_core/doc/index.rst

+Supported Features
+==================
+
+The Zephyr nucleo_h563zi board configuration supports the following hardware features:


Suggested change

The Zephyr nucleo_h563zi board configuration supports the following hardware features:

The Zephyr ``weact_stm32h5_core`` board supports the following hardware features:

nordicjm · 2025-01-20T08:10:29Z

boards/weact/stm32h5_core/weact_stm32h5_core.dts

+	status = "okay";
+	pinctrl-0 = <&usart1_tx_pa9 &usart1_rx_pa10>;
+	pinctrl-names = "default";
+


Suggested change

boards/weact/stm32h5_core/weact_stm32h5_core.dts

JarmouniA · 2025-01-23T17:22:18Z

boards/weact/stm32h5_core/doc/index.rst

+.. _STM32CubeProgrammer:
+   https://www.st.com/en/development-tools/stm32cubeprog.html
+
+.. _OpenOCD official Github mirror:


JarmouniA · 2025-01-23T23:02:11Z

boards/weact/stm32h5_core/doc/index.rst

+   https://www.st.com/resource/en/reference_manual/rm0481-stm32h52333xx-stm32h56263xx-and-stm32h573xx-armbased-32bit-mcus-stmicroelectronics.pdf
+
+.. _STMicroelectronics OpenOCD Github:
+   https://github.com/STMicroelectronics/OpenOCD/tree/openocd-cubeide-r6


still not removed

Sorry, forgot to add it to commit

JarmouniA · 2025-01-24T09:31:30Z

boards/weact/stm32h5_core/weact_stm32h5_core.yaml

+  - xtools
+ram: 640
+flash: 1024
+supported:


Sorry I didn't catch this before, we only put tags here for devices that are enabled in board DTS, I don't see any SPI, I3C, CAN,.. nodes.

JarmouniA

Great work, thanks!

magiczny-kacper · 2025-01-24T19:43:28Z

@JarmouniA thank you too! I have fixed typos to pass CI

nordicjm

Review requested without fixing raised issues

erwango · 2025-01-27T08:16:16Z

boards/weact/stm32h5_core/doc/index.rst

+Replace :code:`<tty_device>` with the port where the board XIAO BLE
+can be found. For example, under Linux, :code:`/dev/ttyACM0`.


Replace :code:`<tty_device>` with the port where the board can be found. For example, under Linux, :code:`/dev/ttyACM0`.

erwango · 2025-01-27T08:21:53Z

boards/weact/stm32h5_core/board.cmake

+board_runner_args(stm32cubeprogrammer "--port=swd" "--reset-mode=hw")
+
+board_runner_args(pyocd "--target=stm32h562rgtx")
+
+board_runner_args(jlink "--device=STM32H562RG" "--reset-after-load")
+
+board_runner_args(dfu-util "--pid=0483:df11" "--alt=0" "--dfuse")
+
+board_runner_args(openocd "--tcl-port=6666")
+board_runner_args(openocd --cmd-pre-init "gdb_report_data_abort enable")
+board_runner_args(openocd "--no-halt")
+
+# Keep first
+include(${ZEPHYR_BASE}/boards/common/stm32cubeprogrammer.board.cmake)
+include(${ZEPHYR_BASE}/boards/common/pyocd.board.cmake)
+include(${ZEPHYR_BASE}/boards/common/jlink.board.cmake)
+include(${ZEPHYR_BASE}/boards/common/openocd.board.cmake)
+include(${ZEPHYR_BASE}/boards/common/dfu-util.board.cmake)


If the only flashing method available is usb-dfu, let's remove others for correctness and clarity.
Users using the board with ST-Link will be able to add required lines.
Optionaly you can keep them commented

erwango · 2025-01-27T08:25:22Z

boards/weact/stm32h5_core/doc/index.rst

+-----------+------------+-------------------------------------+
+| I3C       | on-chip    | i3c bus                             |


Not available, please remove.

erwango · 2025-01-27T08:25:34Z

boards/weact/stm32h5_core/doc/index.rst

+| PWM       | on-chip    | PWM                                 |
+-----------+------------+-------------------------------------+


Not enabled, please remove

erwango · 2025-01-27T08:27:40Z

boards/weact/stm32h5_core/doc/index.rst

+| BKP SRAM  | on-chip    | Backup SRAM                         |
+-----------+------------+-------------------------------------+


Not enabled please remove

erwango · 2025-01-27T08:27:59Z

boards/weact/stm32h5_core/doc/index.rst

+| ADC       | on-chip    | ADC Controller                      |
+-----------+------------+-------------------------------------+


Not enabled, please remove

erwango · 2025-01-27T08:28:10Z

boards/weact/stm32h5_core/doc/index.rst

+| DAC       | on-chip    | DAC Controller                      |
+-----------+------------+-------------------------------------+


Not enabled, please remove.

erwango · 2025-01-27T08:28:36Z

boards/weact/stm32h5_core/weact_stm32h5_core.yaml

+flash: 1024
+supported:
+  - gpio
+  - backup_sram


To be removed.

Low cost STM32H5 series development board with bare minimum to run the MCU Signed-off-by: Kacper Brzostowski <[email protected]>

nordicjm · 2025-02-03T07:59:25Z

boards/weact/stm32h5_core/weact_stm32h5_core.dts

+
+	gpio_keys {
+		compatible = "gpio-keys";
+		button_0: button0 {


nordicjm · 2025-02-03T07:59:29Z

boards/weact/stm32h5_core/weact_stm32h5_core.dts

+
+	leds {
+		compatible = "gpio-leds";
+		led_0: led0 {


zephyrbot added the platform: STM32 ST Micro STM32 label Jan 17, 2025

zephyrbot requested review from djiatsaf-st, erwango, FRASTM, gautierg-st, GeorgeCGV, marwaiehm-st and mathieuchopstm January 17, 2025 22:15

zephyrbot assigned erwango Jan 17, 2025

magiczny-kacper force-pushed the weact_h5_core branch from e290647 to 33b36c2 Compare January 17, 2025 22:23

JarmouniA added the area: Boards label Jan 18, 2025

magiczny-kacper force-pushed the weact_h5_core branch from 45d40a6 to b391224 Compare January 18, 2025 16:40

dts: st: h5: addSTM32H562xG SoC support

522658c

Added STM32H562xG dts file Signed-off-by: Kacper Brzostowski <[email protected]>

magiczny-kacper force-pushed the weact_h5_core branch 2 times, most recently from 5bf7914 to 00aa596 Compare January 19, 2025 11:31

nordicjm reviewed Jan 20, 2025

View reviewed changes

magiczny-kacper force-pushed the weact_h5_core branch 7 times, most recently from 5f8f686 to ffcdc29 Compare January 23, 2025 15:35

zephyrbot added area: ADC Analog-to-Digital Converter (ADC) area: DAC Digital-to-Analog Converter labels Jan 23, 2025

zephyrbot requested review from anangl and martinjaeger January 23, 2025 15:36

JarmouniA removed the request for review from martinjaeger January 23, 2025 16:32

JarmouniA removed area: ADC Analog-to-Digital Converter (ADC) area: DAC Digital-to-Analog Converter labels Jan 23, 2025

magiczny-kacper force-pushed the weact_h5_core branch from ffcdc29 to 48052ad Compare January 23, 2025 17:01

zephyrbot added the area: ADC Analog-to-Digital Converter (ADC) label Jan 23, 2025

zephyrbot requested a review from anangl January 23, 2025 17:02

magiczny-kacper force-pushed the weact_h5_core branch from 48052ad to 80996ff Compare January 23, 2025 17:02

JarmouniA suggested changes Jan 23, 2025

View reviewed changes

JarmouniA removed the request for review from anangl January 23, 2025 17:24

JarmouniA removed the area: ADC Analog-to-Digital Converter (ADC) label Jan 23, 2025

magiczny-kacper force-pushed the weact_h5_core branch 2 times, most recently from 1dc251e to 0c198ee Compare January 23, 2025 18:09

magiczny-kacper requested a review from JarmouniA January 23, 2025 20:32

JarmouniA suggested changes Jan 23, 2025

View reviewed changes

magiczny-kacper force-pushed the weact_h5_core branch from 0c198ee to ceaa8be Compare January 24, 2025 09:17

JarmouniA suggested changes Jan 24, 2025

View reviewed changes

magiczny-kacper force-pushed the weact_h5_core branch from ceaa8be to 50119f0 Compare January 24, 2025 11:01

JarmouniA approved these changes Jan 24, 2025

View reviewed changes

magiczny-kacper force-pushed the weact_h5_core branch 3 times, most recently from 162ad43 to 25e5909 Compare January 24, 2025 14:56

magiczny-kacper requested a review from nordicjm January 25, 2025 11:02

nordicjm requested changes Jan 28, 2025

View reviewed changes

erwango requested changes Jan 28, 2025

View reviewed changes

boards: weact: Add support for WeAct STM32H5 Core Board

c61c7c6

Low cost STM32H5 series development board with bare minimum to run the MCU Signed-off-by: Kacper Brzostowski <[email protected]>

magiczny-kacper force-pushed the weact_h5_core branch from 25e5909 to c61c7c6 Compare January 31, 2025 21:01

magiczny-kacper requested review from nordicjm and erwango February 1, 2025 18:58

nordicjm reviewed Feb 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boards: weact: Add support for WeAct STM32H5 Core Board #84180

boards: weact: Add support for WeAct STM32H5 Core Board #84180

magiczny-kacper commented Jan 17, 2025

github-actions bot commented Jan 17, 2025

JarmouniA commented Jan 18, 2025

JarmouniA commented Jan 18, 2025

nordicjm Jan 20, 2025

nordicjm Jan 20, 2025

JarmouniA Jan 23, 2025

JarmouniA Jan 23, 2025

magiczny-kacper Jan 24, 2025

JarmouniA Jan 24, 2025

JarmouniA left a comment

magiczny-kacper commented Jan 24, 2025 •

edited

Loading

nordicjm left a comment

erwango Jan 27, 2025

magiczny-kacper Jan 31, 2025

erwango Jan 27, 2025

magiczny-kacper Jan 31, 2025

erwango Jan 27, 2025

magiczny-kacper Jan 31, 2025

erwango Jan 27, 2025

magiczny-kacper Jan 31, 2025

erwango Jan 27, 2025

magiczny-kacper Jan 31, 2025

erwango Jan 27, 2025

magiczny-kacper Jan 31, 2025

erwango Jan 27, 2025

magiczny-kacper Jan 31, 2025

erwango Jan 27, 2025

magiczny-kacper Jan 31, 2025

nordicjm Feb 3, 2025

nordicjm Feb 3, 2025

	The Zephyr nucleo_h563zi board configuration supports the following hardware features:
	The Zephyr ``weact_stm32h5_core`` board supports the following hardware features:

		Replace :code:`<tty_device>` with the port where the board XIAO BLE
		can be found. For example, under Linux, :code:`/dev/ttyACM0`.

		+-----------+------------+-------------------------------------+
		\| I3C \| on-chip \| i3c bus \|

		\| PWM \| on-chip \| PWM \|
		+-----------+------------+-------------------------------------+

		\| BKP SRAM \| on-chip \| Backup SRAM \|
		+-----------+------------+-------------------------------------+

		\| ADC \| on-chip \| ADC Controller \|
		+-----------+------------+-------------------------------------+

		\| DAC \| on-chip \| DAC Controller \|
		+-----------+------------+-------------------------------------+

boards: weact: Add support for WeAct STM32H5 Core Board #84180

Are you sure you want to change the base?

boards: weact: Add support for WeAct STM32H5 Core Board #84180

Conversation

magiczny-kacper commented Jan 17, 2025

github-actions bot commented Jan 17, 2025

JarmouniA commented Jan 18, 2025

JarmouniA commented Jan 18, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JarmouniA left a comment

Choose a reason for hiding this comment

magiczny-kacper commented Jan 24, 2025 • edited Loading

nordicjm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

magiczny-kacper commented Jan 24, 2025 •

edited

Loading