Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: wifi: CONFIG_MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG updates #84517

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

frkv
Copy link
Collaborator

@frkv frkv commented Jan 24, 2025

  • Update hostap to [noup] zephyr: Update to support MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG hostap#76 which adds support for CONFIG_MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG instead of relying on legacy Mbed TLS ctr_drbg and entropy APIs. This change is in line with PSA crypto entropy changes in Zephyr happening with TinyCrypt deprecation and advancement of PSA crypto mechanisms
  • Remove defconfigs for currently sets the Kconfigs:
-CONFIG_MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG
-CONFIG_MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG_ALLOW_NON_CSPRNG

@zephyrbot
Copy link
Collaborator

zephyrbot commented Jan 24, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hostap zephyrproject-rtos/hostap@b4c42d8 zephyrproject-rtos/hostap@219b1f7 zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hostap DNM This PR should not be merged (Do Not Merge) labels Jan 24, 2025
@frkv frkv force-pushed the hostap_external_rng branch from 1b7ba83 to 8b9c57a Compare January 27, 2025 07:47
@frkv frkv requested a review from krish2718 January 27, 2025 09:07
@frkv frkv marked this pull request as ready for review January 27, 2025 09:46
@zephyrbot zephyrbot added the platform: nRF Nordic nRFx label Jan 27, 2025
@frkv frkv force-pushed the hostap_external_rng branch from 8b9c57a to d55efcd Compare January 28, 2025 08:23
@zephyrbot zephyrbot added the area: Wi-Fi Wi-Fi label Jan 28, 2025
@frkv frkv force-pushed the hostap_external_rng branch from c081a48 to c65c31c Compare January 28, 2025 11:43
@fabiobaltieri fabiobaltieri added DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed DNM This PR should not be merged (Do Not Merge) labels Feb 4, 2025
MaochenWang1
MaochenWang1 previously approved these changes Feb 5, 2025
west.yml Outdated
@@ -274,7 +274,7 @@ manifest:
- hal
- name: hostap
path: modules/lib/hostap
revision: b4c42d88afc5ee04751fe258db757c4ef70abb09
revision: pull/76/head
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update with SHA: 219b1f75d6452aafd1aff1912cc07dd132f753fa.

frkv added 3 commits February 11, 2025 15:25
-Update hostap to PR zephyrproject-rtos#76 which adds support for
 CONFIG_MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG instead of relying on legacy
 Mbed TLS ctr_drbg and entropy APIs. This change is in line with
 PSA crypto entropy changes in Zephyr happening with TinyCrypt
 deprecation and advancement of PSA crypto mechanisms
-Remove defconfigs for currently sets the Kconfigs:
 -CONFIG_MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG
 -CONFIG_MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG_ALLOW_NON_CSPRNG

Signed-off-by: Frank Audun Kvamtrø <[email protected]>
-PSA_WANT_ALG_CMAC must be set for PSA_WANT_ALG_PBKDF2_AES_CMAC_PRF_128
 to be valid. This commit fixes this mismatch for hostap

Signed-off-by: Frank Audun Kvamtrø <[email protected]>
-Mbed TLS has come up with its own naming-convention with regards
 to certain Mbed TLS configurations for TLS/DTLS and X.509. This
 commit fixes a couple of them by depending on MBEDTLS_BUILTIN
 which is set when Kconfig.tls-generic is used
 1. Make MBEDTLS_PEM_CERTIFICATE_FORMAT depend on MBEDTLS_BUILTIN
    The proper name for this functionaity is MBEDTL_PEM_PARSE_C and
    MBEDTLS_PEM_WRITE_C
 2. Make MBEDTLS_SERVER_NAME_INDICATION depend on MBEDTLS_BUILTIN
    The proper name for this is MBEDTLS_SSL_SERVER_NAME_INDICATION

Signed-off-by: Frank Audun Kvamtrø <[email protected]>
@zephyrbot zephyrbot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants