Skip to content

Commit

Permalink
Fix logging documentation (go-gitea#6904)
Browse files Browse the repository at this point in the history
* ENABLE_MACARON_REDIRECT should be REDIRECT_MACARON_LOG

* Allow DISABLE_ROUTER_LOG to be set in the [log] section
  • Loading branch information
zeripath committed May 11, 2019
1 parent d90115f commit 5f8cb40
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/content/doc/advanced/logging-documentation.en-us.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ multiple subloggers that will log to files.

By default Macaron will log to its own go `log` instance. This writes
to `os.Stdout`. You can redirect this log to a Gitea configurable logger
through setting the `ENABLE_MACARON_REDIRECT` setting in the `[log]`
through setting the `REDIRECT_MACARON_LOG` setting in the `[log]`
section which you can configure the outputs of by setting the `MACARON`
value in the `[log]` section of the configuration. `MACARON` defaults
to `file` if unset.
Expand All @@ -89,7 +89,7 @@ log using the value: `MACARON = ,`

There are two types of Router log. By default Macaron send its own
router log which will be directed to Macaron's go `log`, however if you
`ENABLE_MACARON_REDIRECT` you will enable Gitea's router log. You can
`REDIRECT_MACARON_LOG` you will enable Gitea's router log. You can
disable both types of Router log by setting `DISABLE_ROUTER_LOG`.

If you enable the redirect, you can configure the outputs of this
Expand Down
2 changes: 2 additions & 0 deletions modules/setting/log.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ func newAccessLogService() {

func newRouterLogService() {
Cfg.Section("log").Key("ROUTER").MustString("console")
// Allow [log] DISABLE_ROUTER_LOG to override [server] DISABLE_ROUTER_LOG
DisableRouterLog = Cfg.Section("log").Key("DISABLE_ROUTER_LOG").MustBool(DisableRouterLog)

if !DisableRouterLog && RedirectMacaronLog {
options := newDefaultLogOptions()
Expand Down

0 comments on commit 5f8cb40

Please sign in to comment.