Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: global fields apply to Third-party log module #4400

Merged
merged 2 commits into from
Jan 31, 2025
Merged

fix: global fields apply to Third-party log module #4400

merged 2 commits into from
Jan 31, 2025

Conversation

JiChenSSG
Copy link
Contributor

@JiChenSSG JiChenSSG commented Sep 29, 2024 •
edited by kevwan
Loading

fix #4398

@codecov Codecov
Copy link

codecov bot commented Sep 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (8690859) to head (bbe5d8d).
Report is 245 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
core/logx/logs.go 99.07% <100.00%> (+0.15%) ⬆️
core/logx/richlogger.go 100.00% <100.00%> (ø)
core/logx/writer.go 96.20% <ø> (+0.66%) ⬆️

... and 7 files with indirect coverage changes

@kevwan kevwan marked this as a duplicate of #4616 Jan 31, 2025
@kevwan kevwan added this pull request to the merge queue Jan 31, 2025
Merged via the queue into zeromicro:master with commit 84db9bc Jan 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The AddGlobalFields function fails after using the integrated zap component zapx as a writer
2 participants
@JiChenSSG @kevwan