Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 8.2 deprecations #228

Merged
merged 1 commit into from
Jan 6, 2023
Merged

fix 8.2 deprecations #228

merged 1 commit into from
Jan 6, 2023

Conversation

remicollet
Copy link
Contributor

TEST 7/65 [tests/007-addremovepoll.phpt]
========DIFF========
001+ Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /work/GIT/pecl-and-ext/zmq/tests/007-addremovepoll.php on line 14
002+ 
003+ Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /work/GIT/pecl-and-ext/zmq/tests/007-addremovepoll.php on line 21
     string(34) "o:%s"
     string(3) "r:%d"
     int(2)
--
========DONE========
FAIL Test adding / removing items [tests/007-addremovepoll.phpt] 

TEST 36/65 [tests/036-device.phpt]
========DIFF========
001+ Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /work/GIT/pecl-and-ext/zmq/tests/036-device.php on line 54
002+ 
003+ Deprecated: Creation of dynamic property CbStateData::$name is deprecated in /work/GIT/pecl-and-ext/zmq/tests/036-device.php on line 13
     Triggered for 100ms timeout
     timer function called 1 times
     Triggered for 150ms timeout
--
========DONE========
FAIL Test device callbacks [tests/036-device.phpt] 

TEST 37/65 [tests/037-device-deprecated.phpt]
========DIFF========
001+ Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /work/GIT/pecl-and-ext/zmq/tests/037-device-deprecated.php on line 10
002+ 
     Deprecated: ZMQDevice::setidlecallback(): The signature for setIdleCallback has changed, please update your code in %s on line %d
     Called: test
     OK
========DONE========
FAIL Test device deprecated args [tests/037-device-deprecated.phpt] 

TEST 48/65 [tests/048-pollsetitems.phpt]
========DIFF========
001+ Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /work/GIT/pecl-and-ext/zmq/tests/048-pollsetitems.php on line 12
002+ 
003+ Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /work/GIT/pecl-and-ext/zmq/tests/048-pollsetitems.php on line 19
     array(3) {
       ["o:%s"]=>
       object(ZMQSocket)#%d (%d) {
--
========DONE========
FAIL Test pollset items [tests/048-pollsetitems.phpt]


@Danny-Smart
Copy link

Could we have some movement on this PR please?

We're currently having to build from @remicollet's fork to use ZMQ with PHP8.2, which is obviously not ideal

@bluca bluca merged commit 84f0720 into zeromq:master Jan 6, 2023
@Danny-Smart
Copy link

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants