Smoke test with non-legacy yarn version #696
Draft
+124
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows this package to be used as a dependency (in built form) even when the compilation tools can't be installed.
aminya
requested changes
Jan 6, 2025
| @@ -308,7 +308,7 @@ jobs: | |||
| - name: Install Yarn Latest | |||
| if: matrix.node-version == 22 | |||
| run: | | |||
| npm i -g yarn@latest | |||
| npm i -g @yarnpkg/cli-dist@latest | |||
There was a problem hiding this comment.
Could you separate any change other than the version bump?
There was a problem hiding this comment.
Yeah. Moving this back to draft while I figure out what all is needed to make the smoke tests pass then I'll split it up as needed.
This is only needed if you're building from source
# Conflicts: # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confusingly,
npm install yarn@latestinstalls a very old version 1.22.22. The latest version of yarn is 4.6.0, published as@yarnpkg/cliand@yarnpkg/cli-dist.https://github.com/zeromq/zeromq.js/actions/runs/12553326958/job/35000759612#step:9:168