Remove extra vertical space for any label with no message set #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @zesterer !
There is an issue where the library stills draw extra spaces for labels with no messages, the library still allocate a line regardless if the label has an arrow to display.
This was reported by @kaikalii in #51, adding a check here seems to fix the issue.
ariadne/src/write.rs
Lines 606 to 609 in 8225799
however there's still some issues with multiline labels, i need you to determine how this can be handled :
Also, i could'nt find an efficient way to write tests for this PR, thus i allowed myself to add a new example to prove the fix.
other examples