Fix TypeError on Python 2.7 and git-lfs issue #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use p.communicate() instead of of .read() on stderr/stdout directly as that seems to cause a deadlock with large outputs (or at least that is what I think happens). Before this change zest.releaser would get stuck doing a clone of the repository, if the repository uses git-lfs.
This fixes ``TypeError: environment can only contain strings`` emitted by subprocess. Subprocess seems to dislike unicode objects in os.environ/env that is passed. This assures a plain string is used instead.
mauritsvanrees
approved these changes
Sep 3, 2020
|
I have released 6.22.0 with your fixes. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bumped into a couple of issues using the latest version of zest.releaser under python 2.7, while trying to release code that uses git and git-lfs.
This PR address both these issues.