chore: revert cometbft upgrade #3065
Conversation
This reverts commit 9b285c2.
gartnera
requested review from
brewmaster012,
kingpinXD,
lumtis,
ws4charlie,
skosito,
swift1337 and
fbac
as code owners
📝 WalkthroughWalkthroughThe changes in this pull request involve significant downgrades of various dependencies in the Changes
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
gartnera
force-pushed
the
revert-cometbft-upgrade
branch
from
c3f5a45 to
caf9333
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
go.mod (1)
306-308: Review OpenTelemetry integration.
The OpenTelemetry stack has been downgraded from v1.24.0 to v1.21.0. This could affect observability and tracing capabilities.
Consider documenting any changes in telemetry behavior or feature availability in the monitoring documentation.
Also applies to: 348-349
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
- go.mod (13 hunks)
🔇 Additional comments (3)
go.mod (3)
Line range hint 353-374: Verify custom fork maintenance.
The project maintains several critical forks of upstream dependencies. Ensure these forks are compatible with the downgraded versions.
#!/bin/bash
# Check custom fork references
for fork in "zeta-chain/tss-lib" "zeta-chain/go-ethereum" "zeta-chain/go-libp2p" "zeta-chain/go-tss"; do
echo "Checking $fork..."
gh api "repos/$fork" --jq '.default_branch, .updated_at'
done34-34: Verify secondary dependency compatibility.
The downgrade of secondary dependencies (websocket, prometheus, cobra, viper) might affect system monitoring and CLI functionality.
#!/bin/bash
# Check for usage of features from newer versions
rg -l "prometheus\.New|cobra\.Version|viper\.GetViper" --type goAlso applies to: 49-49, 56-56, 58-58
17-20: Verify CometBFT downgrade compatibility.
The downgrade of CometBFT and related packages aligns with the PR objective to revert breaking changes. However, this significant version rollback requires careful verification.
This cometbft-db upgrade is a breaking change which caused zeta database corruption (or at least consensus failures) on their cosmos sdk v0.47.x application when upgrading: zeta-chain/node#3045 (revert with details: zeta-chain/node#3065) zeta-chain/node#3045 zeta-chain/node#3065
Revert #3045
It includes this which is a breaking change that would probably require cosmos sdk changes: cometbft/cometbft-db#168 (updated in cometbft/cometbft#4321)
zetacore1-logs-snip.txt
Summary by CodeRabbit