Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fungible): ZRC20 Lock/Unlock API should not depend on injected ABI #3068

Merged
merged 2 commits into from
Oct 30, 2024

Merge branch 'develop' into refactor/zrc20-fungible-api-independent

defdb49
Select commit
Loading
Failed to load commit list.
Merged

refactor(fungible): ZRC20 Lock/Unlock API should not depend on injected ABI #3068

Merge branch 'develop' into refactor/zrc20-fungible-api-independent
defdb49
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 30, 2024 in 0s

64.29% (-0.04%) compared to 648d2e3

View this Pull Request on Codecov

64.29% (-0.04%) compared to 648d2e3

Details

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 64.29%. Comparing base (648d2e3) to head (defdb49).

Files with missing lines Patch % Lines
x/fungible/keeper/zrc20_methods.go 33.33% 5 Missing and 5 partials ⚠️
precompiles/bank/method_withdraw.go 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3068      +/-   ##
===========================================
- Coverage    64.33%   64.29%   -0.04%     
===========================================
  Files          419      419              
  Lines        29102    29076      -26     
===========================================
- Hits         18723    18695      -28     
  Misses        9597     9597              
- Partials       782      784       +2     
Files with missing lines Coverage Δ
precompiles/bank/bank.go 77.65% <ø> (+2.65%) ⬆️
precompiles/bank/method_deposit.go 42.85% <100.00%> (-2.70%) ⬇️
precompiles/staking/method_distribute.go 46.15% <100.00%> (ø)
precompiles/staking/staking.go 69.18% <ø> (+1.30%) ⬆️
x/fungible/keeper/zrc20_cosmos_coins_mapping.go 67.39% <100.00%> (-2.00%) ⬇️
precompiles/bank/method_withdraw.go 20.45% <0.00%> (ø)
x/fungible/keeper/zrc20_methods.go 57.35% <33.33%> (-6.47%) ⬇️