Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zetaclient): orchestrator: signer resolution #3139

Merged
merged 4 commits into from
Nov 12, 2024

Merge branch 'develop' into fix/orchestrator-logging

d521d58
Select commit
Loading
Failed to load commit list.
Merged

fix(zetaclient): orchestrator: signer resolution #3139

Merge branch 'develop' into fix/orchestrator-logging
d521d58
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2024 in 0s

63.08% (-0.07%) compared to 1738618

View this Pull Request on Codecov

63.08% (-0.07%) compared to 1738618

Details

Codecov Report

Attention: Patch coverage is 45.76271% with 32 lines in your changes missing coverage. Please review.

Project coverage is 63.08%. Comparing base (1738618) to head (d521d58).

Files with missing lines Patch % Lines
zetaclient/chains/evm/signer/signer.go 41.17% 18 Missing and 2 partials ⚠️
zetaclient/chains/solana/signer/signer.go 57.14% 4 Missing and 2 partials ⚠️
zetaclient/chains/ton/signer/signer.go 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3139      +/-   ##
===========================================
- Coverage    63.15%   63.08%   -0.07%     
===========================================
  Files          423      423              
  Lines        29872    29875       +3     
===========================================
- Hits         18865    18848      -17     
- Misses       10169    10186      +17     
- Partials       838      841       +3     
Files with missing lines Coverage Δ
zetaclient/orchestrator/orchestrator.go 18.56% <100.00%> (-3.91%) ⬇️
zetaclient/chains/solana/signer/signer.go 29.72% <57.14%> (-0.22%) ⬇️
zetaclient/chains/ton/signer/signer.go 45.12% <0.00%> (-1.42%) ⬇️
zetaclient/chains/evm/signer/signer.go 46.11% <41.17%> (-0.72%) ⬇️