Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: (BitcoinRBF-Step2): some minimum code refactoring for Bitcoin RBF adoption #3381

Merged
merged 48 commits into from
Feb 4, 2025

add changelog entry

2481654
Select commit
Loading
Failed to load commit list.
Merged

refactor: (BitcoinRBF-Step2): some minimum code refactoring for Bitcoin RBF adoption #3381

add changelog entry
2481654
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 0s

63.73% (+0.50%) compared to 078dbef

View this Pull Request on Codecov

63.73% (+0.50%) compared to 078dbef

Details

Codecov Report

Attention: Patch coverage is 49.77169% with 330 lines in your changes missing coverage. Please review.

Project coverage is 63.73%. Comparing base (078dbef) to head (2481654).

Files with missing lines Patch % Lines
zetaclient/chains/bitcoin/observer/outbound.go 4.49% 85 Missing ⚠️
zetaclient/chains/bitcoin/signer/sign.go 50.00% 75 Missing and 4 partials ⚠️
zetaclient/chains/bitcoin/observer/gas_price.go 0.00% 45 Missing ⚠️
zetaclient/chains/bitcoin/observer/utxos.go 62.71% 42 Missing and 2 partials ⚠️
zetaclient/chains/bitcoin/signer/signer.go 57.62% 23 Missing and 2 partials ⚠️
zetaclient/chains/bitcoin/client/helpers.go 0.00% 23 Missing ⚠️
zetaclient/orchestrator/orchestrator.go 0.00% 14 Missing ⚠️
zetaclient/chains/bitcoin/observer/db.go 78.57% 7 Missing and 2 partials ⚠️
zetaclient/chains/bitcoin/common/fee.go 87.50% 2 Missing ⚠️
zetaclient/chains/bitcoin/observer/observer.go 87.50% 2 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3381      +/-   ##
===========================================
+ Coverage    63.22%   63.73%   +0.50%     
===========================================
  Files          436      441       +5     
  Lines        30639    30704      +65     
===========================================
+ Hits         19372    19569     +197     
+ Misses       10432    10295     -137     
- Partials       835      840       +5     
Files with missing lines Coverage Δ
zetaclient/chains/bitcoin/signer/outbound_data.go 100.00% <100.00%> (ø)
zetaclient/orchestrator/v2_bootstrap.go 65.90% <ø> (ø)
zetaclient/testutils/testdata.go 87.02% <100.00%> (+0.36%) ⬆️
zetaclient/testutils/testdata_naming.go 80.85% <100.00%> (+0.85%) ⬆️
zetaclient/zetacore/broadcast.go 59.16% <100.00%> (+0.34%) ⬆️
zetaclient/chains/bitcoin/common/fee.go 42.23% <87.50%> (+3.21%) ⬆️
zetaclient/chains/bitcoin/observer/observer.go 82.82% <87.50%> (+45.54%) ⬆️
zetaclient/chains/evm/signer/signer.go 44.32% <0.00%> (ø)
zetaclient/chains/bitcoin/observer/db.go 78.57% <78.57%> (ø)
zetaclient/orchestrator/orchestrator.go 19.68% <0.00%> (ø)
... and 6 more