Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: (BitcoinRBF-Step2): some minimum code refactoring for Bitcoin RBF adoption #3381

Merged
merged 48 commits into from
Feb 4, 2025
+2,719 −1,397

add unit test for FeeRateToSatPerByte

111d703
Select commit
Loading
Failed to load commit list.
Merged

refactor: (BitcoinRBF-Step2): some minimum code refactoring for Bitcoin RBF adoption #3381

add unit test for FeeRateToSatPerByte
111d703
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 21, 2025 in 1s

50.30% of diff hit (target 63.22%)

View this Pull Request on Codecov

50.30% of diff hit (target 63.22%)

Annotations

Check warning on line 122 in zetaclient/chains/bitcoin/client/helpers.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/client/helpers.go#L118-L122 

Added lines #L118 - L122 were not covered by tests

Check warning on line 136 in zetaclient/chains/bitcoin/client/helpers.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/client/helpers.go#L124-L136 

Added lines #L124 - L136 were not covered by tests

Check warning on line 138 in zetaclient/chains/bitcoin/client/helpers.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/client/helpers.go#L138 

Added line #L138 was not covered by tests

Check warning on line 260 in zetaclient/chains/bitcoin/common/fee.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/common/fee.go#L260 

Added line #L260 was not covered by tests

Check warning on line 300 in zetaclient/chains/bitcoin/common/fee.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/common/fee.go#L300 

Added line #L300 was not covered by tests

Check warning on line 25 in zetaclient/chains/bitcoin/observer/db.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/db.go#L22-L25 

Added lines #L22 - L25 were not covered by tests

Check warning on line 63 in zetaclient/chains/bitcoin/observer/db.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/db.go#L61-L63 

Added lines #L61 - L63 were not covered by tests

Check warning on line 34 in zetaclient/chains/bitcoin/observer/gas_price.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/gas_price.go#L15-L34 

Added lines #L15 - L34 were not covered by tests

Check warning on line 41 in zetaclient/chains/bitcoin/observer/gas_price.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/gas_price.go#L38-L41 

Added lines #L38 - L41 were not covered by tests

Check warning on line 51 in zetaclient/chains/bitcoin/observer/gas_price.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/gas_price.go#L44-L51 

Added lines #L44 - L51 were not covered by tests

Check warning on line 53 in zetaclient/chains/bitcoin/observer/gas_price.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/gas_price.go#L53 

Added line #L53 was not covered by tests

Check warning on line 68 in zetaclient/chains/bitcoin/observer/gas_price.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/gas_price.go#L57-L68 

Added lines #L57 - L68 were not covered by tests

Check warning on line 269 in zetaclient/chains/bitcoin/observer/observer.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/observer.go#L268-L269 

Added lines #L268 - L269 were not covered by tests

Check warning on line 41 in zetaclient/chains/bitcoin/observer/outbound.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/outbound.go#L38-L41 

Added lines #L38 - L41 were not covered by tests

Check warning on line 46 in zetaclient/chains/bitcoin/observer/outbound.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/outbound.go#L43-L46 

Added lines #L43 - L46 were not covered by tests

Check warning on line 50 in zetaclient/chains/bitcoin/observer/outbound.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/outbound.go#L49-L50 

Added lines #L49 - L50 were not covered by tests

Check warning on line 53 in zetaclient/chains/bitcoin/observer/outbound.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/outbound.go#L53 

Added line #L53 was not covered by tests

Check warning on line 66 in zetaclient/chains/bitcoin/observer/outbound.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/outbound.go#L64-L66 

Added lines #L64 - L66 were not covered by tests

Check warning on line 95 in zetaclient/chains/bitcoin/observer/outbound.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/outbound.go#L88-L95 

Added lines #L88 - L95 were not covered by tests

Check warning on line 97 in zetaclient/chains/bitcoin/observer/outbound.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/outbound.go#L97 

Added line #L97 was not covered by tests

Check warning on line 101 in zetaclient/chains/bitcoin/observer/outbound.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/outbound.go#L101 

Added line #L101 was not covered by tests

Check warning on line 126 in zetaclient/chains/bitcoin/observer/outbound.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/outbound.go#L124-L126 

Added lines #L124 - L126 were not covered by tests

Check warning on line 144 in zetaclient/chains/bitcoin/observer/outbound.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/outbound.go#L143-L144 

Added lines #L143 - L144 were not covered by tests

Check warning on line 232 in zetaclient/chains/bitcoin/observer/outbound.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/outbound.go#L232 

Added line #L232 was not covered by tests

Check warning on line 234 in zetaclient/chains/bitcoin/observer/outbound.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

zetaclient/chains/bitcoin/observer/outbound.go#L234 

Added line #L234 was not covered by tests
View more details on Codecov